Skip to content

Commit

Permalink
Merge pull request kubernetes#111440 from verb/111025-ec-conformance
Browse files Browse the repository at this point in the history
Promote Ephemeral Containers e2e test to Conformance
  • Loading branch information
k8s-ci-robot committed Aug 8, 2022
2 parents 0d9aaf1 + 14ee775 commit 25a3274
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
7 changes: 7 additions & 0 deletions test/conformance/testdata/conformance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1871,6 +1871,13 @@
visible at runtime in the container.
release: v1.9
file: test/e2e/common/node/downwardapi.go
- testname: Ephemeral Container Creation
codename: '[sig-node] Ephemeral Containers [NodeConformance] will start an ephemeral
container in an existing pod [Conformance]'
description: Adding an ephemeral container to pod.spec MUST result in the container
running.
release: "1.25"
file: test/e2e/common/node/ephemeral_containers.go
- testname: init-container-starts-app-restartalways-pod
codename: '[sig-node] InitContainer [NodeConformance] should invoke init containers
on a RestartAlways pod [Conformance]'
Expand Down
5 changes: 4 additions & 1 deletion test/e2e/common/node/ephemeral_containers.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ var _ = SIGDescribe("Ephemeral Containers [NodeConformance]", func() {
podClient = f.PodClient()
})

ginkgo.It("will start an ephemeral container in an existing pod", func() {
// Release: 1.25
// Testname: Ephemeral Container Creation
// Description: Adding an ephemeral container to pod.spec MUST result in the container running.
framework.ConformanceIt("will start an ephemeral container in an existing pod", func() {
ginkgo.By("creating a target pod")
pod := podClient.CreateSync(&v1.Pod{
ObjectMeta: metav1.ObjectMeta{Name: "ephemeral-containers-target-pod"},
Expand Down

0 comments on commit 25a3274

Please sign in to comment.