Skip to content

Commit

Permalink
Merge pull request kubernetes#123628 from Jefftree/agg-conformance
Browse files Browse the repository at this point in the history
promote aggregated discovery conformance tests
  • Loading branch information
k8s-ci-robot committed Mar 4, 2024
2 parents 6c8dc1d + ebcb78d commit 320e288
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 6 deletions.
29 changes: 29 additions & 0 deletions test/conformance/testdata/conformance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,35 @@
all MUST be denied.
release: v1.16
file: test/e2e/apimachinery/webhook.go
- testname: Aggregated Discovery Interface
codename: '[sig-api-machinery] AggregatedDiscovery should support aggregated discovery
interface [Conformance]'
description: An apiserver MUST support the Aggregated Discovery client interface.
Built-in resources MUST all be present.
release: v1.30
file: test/e2e/apimachinery/aggregated_discovery.go
- testname: Aggregated Discovery Interface CRDs
codename: '[sig-api-machinery] AggregatedDiscovery should support aggregated discovery
interface for CRDs [Conformance]'
description: An apiserver MUST support the Aggregated Discovery client interface.
Add a CRD to the apiserver. The CRD resource MUST be present in the discovery
document.
release: v1.30
file: test/e2e/apimachinery/aggregated_discovery.go
- testname: Aggregated Discovery Endpoint Accept Headers
codename: '[sig-api-machinery] AggregatedDiscovery should support raw aggregated
discovery endpoint Accept headers [Conformance]'
description: An apiserver MUST support the Aggregated Discovery endpoint Accept
headers. Built-in resources MUST all be present.
release: v1.30
file: test/e2e/apimachinery/aggregated_discovery.go
- testname: Aggregated Discovery Endpoint Accept Headers CRDs
codename: '[sig-api-machinery] AggregatedDiscovery should support raw aggregated
discovery request for CRDs [Conformance]'
description: An apiserver MUST support the Aggregated Discovery endpoint Accept
headers. Add a CRD to the apiserver. The CRD MUST appear in the discovery document.
release: v1.30
file: test/e2e/apimachinery/aggregated_discovery.go
- testname: aggregator-supports-the-sample-apiserver
codename: '[sig-api-machinery] Aggregator Should be able to support the 1.17 Sample
API Server using the current Aggregator [Conformance]'
Expand Down
10 changes: 4 additions & 6 deletions test/e2e/apimachinery/aggregated_discovery.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ import (
"k8s.io/client-go/dynamic"
"k8s.io/kubernetes/test/e2e/framework"
admissionapi "k8s.io/pod-security-admission/api"

"github.com/onsi/ginkgo/v2"
)

var _ = SIGDescribe("AggregatedDiscovery", func() {
Expand Down Expand Up @@ -150,7 +148,7 @@ var _ = SIGDescribe("AggregatedDiscovery", func() {
Testname: Aggregated Discovery Endpoint Accept Headers
Description: An apiserver MUST support the Aggregated Discovery endpoint Accept headers. Built-in resources MUST all be present.
*/
ginkgo.It("should support raw aggregated discovery endpoint Accept headers", func(ctx context.Context) {
framework.ConformanceIt("should support raw aggregated discovery endpoint Accept headers", func(ctx context.Context) {
d, err := f.ClientSet.Discovery().RESTClient().Get().AbsPath("/apis").SetHeader("Accept", aggregatedAccept).Do(ctx).Raw()
if err != nil {
framework.Failf("Failed to get raw aggregated discovery document")
Expand Down Expand Up @@ -193,7 +191,7 @@ var _ = SIGDescribe("AggregatedDiscovery", func() {
Description: An apiserver MUST support the Aggregated Discovery endpoint Accept headers.
Add a CRD to the apiserver. The CRD MUST appear in the discovery document.
*/
ginkgo.It("should support raw aggregated discovery request for CRDs", func(ctx context.Context) {
framework.ConformanceIt("should support raw aggregated discovery request for CRDs", func(ctx context.Context) {
config, err := framework.LoadConfig()
framework.ExpectNoError(err)
apiExtensionClient, err := apiextensionclientset.NewForConfig(config)
Expand Down Expand Up @@ -258,7 +256,7 @@ var _ = SIGDescribe("AggregatedDiscovery", func() {
Testname: Aggregated Discovery Interface
Description: An apiserver MUST support the Aggregated Discovery client interface. Built-in resources MUST all be present.
*/
ginkgo.It("should support aggregated discovery interface", func(ctx context.Context) {
framework.ConformanceIt("should support aggregated discovery interface", func(ctx context.Context) {
d := f.ClientSet.Discovery()

ad, ok := d.(clientdiscovery.AggregatedDiscoveryInterface)
Expand Down Expand Up @@ -302,7 +300,7 @@ var _ = SIGDescribe("AggregatedDiscovery", func() {
Description: An apiserver MUST support the Aggregated Discovery client interface.
Add a CRD to the apiserver. The CRD resource MUST be present in the discovery document.
*/
ginkgo.It("should support aggregated discovery interface for CRDs", func(ctx context.Context) {
framework.ConformanceIt("should support aggregated discovery interface for CRDs", func(ctx context.Context) {
config, err := framework.LoadConfig()
framework.ExpectNoError(err)
apiExtensionClient, err := apiextensionclientset.NewForConfig(config)
Expand Down

0 comments on commit 320e288

Please sign in to comment.