Skip to content

Commit

Permalink
Fix CSR test to accept certs shorter than the requested duration
Browse files Browse the repository at this point in the history
  • Loading branch information
liggitt committed Oct 1, 2021
1 parent 39a3dc8 commit 407cc91
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test/e2e/auth/certificates.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,10 @@ var _ = SIGDescribe("Certificates API [Privileged:ClusterAdmin]", func() {
framework.ExpectNoError(err)
framework.ExpectEqual(len(certs), 1, "expected a single cert, got %#v", certs)
cert := certs[0]
framework.ExpectEqual(cert.NotAfter.Sub(cert.NotBefore), time.Hour+5*time.Minute, "unexpected cert duration: %s", dynamiccertificates.GetHumanCertDetail(cert))
// make sure the cert is not valid for longer than our requested time (plus allowance for backdating)
if e, a := time.Hour+5*time.Minute, cert.NotAfter.Sub(cert.NotBefore); a > e {
framework.Failf("expected cert valid for %s or less, got %s: %s", e, a, dynamiccertificates.GetHumanCertDetail(cert))
}

newClient, err := certificatesclient.NewForConfig(rcfg)
framework.ExpectNoError(err)
Expand Down

0 comments on commit 407cc91

Please sign in to comment.