Skip to content

Commit

Permalink
Merge pull request #82 from soltysh/fix_convert_4.2
Browse files Browse the repository at this point in the history
UPSTREAM: <carry>: OpenShift types conversion
  • Loading branch information
deads2k committed Sep 13, 2019
2 parents 72b04b9 + f4f8c92 commit 4547c3b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 75 deletions.
10 changes: 1 addition & 9 deletions pkg/kubectl/cmd/convert/convert.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,14 +145,6 @@ func (o *ConvertOptions) RunConvert() error {
// Another possible solution is to make convert a plugin.
fmt.Fprintf(o.ErrOut, "kubectl convert is DEPRECATED and will be removed in a future version.\nIn order to convert, kubectl apply the object to the cluster, then kubectl get at the desired version.\n")

ok, err := o.containsOpenShiftTypes()
if err != nil {
return err
}
if ok {
return nil
}

b := o.builder().
WithScheme(scheme.Scheme).
LocalParam(o.local)
Expand All @@ -170,7 +162,7 @@ func (o *ConvertOptions) RunConvert() error {
Flatten().
Do()

err = r.Err()
err := r.Err()
if err != nil {
return err
}
Expand Down
66 changes: 0 additions & 66 deletions pkg/kubectl/cmd/convert/patch_convert_openshift.go

This file was deleted.

0 comments on commit 4547c3b

Please sign in to comment.