Skip to content

Commit

Permalink
Merge pull request kubernetes#114309 from logicalhan/revert
Browse files Browse the repository at this point in the history
Revert "expose prometheus.Registerer so that we can hook into this from external sources"
  • Loading branch information
k8s-ci-robot committed Dec 6, 2022
2 parents 17bf864 + 7887a42 commit 86f3fa9
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions staging/src/k8s.io/component-base/metrics/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,6 @@ type KubeRegistry interface {
Reset()
// RegisterMetaMetrics registers metrics about the number of registered metrics.
RegisterMetaMetrics()
// Registerer exposes the underlying prometheus registerer
Registerer() prometheus.Registerer
// Gatherer exposes the underlying prometheus gatherer
Gatherer() prometheus.Gatherer
}

// kubeRegistry is a wrapper around a prometheus registry-type object. Upon initialization
Expand Down Expand Up @@ -192,16 +188,6 @@ func (kr *kubeRegistry) Register(c Registerable) error {
return nil
}

// Registerer exposes the underlying prometheus.Registerer
func (kr *kubeRegistry) Registerer() prometheus.Registerer {
return kr.PromRegistry
}

// Gatherer exposes the underlying prometheus.Gatherer
func (kr *kubeRegistry) Gatherer() prometheus.Gatherer {
return kr.PromRegistry
}

// MustRegister works like Register but registers any number of
// Collectors and panics upon the first registration that causes an
// error.
Expand Down

0 comments on commit 86f3fa9

Please sign in to comment.