Skip to content

Commit

Permalink
Mark some storage tests as LinuxOnly
Browse files Browse the repository at this point in the history
Some storage tests has commands not available in Windows. Mark them as
LinuxOnly now. Will check later to see whether equivalent windows
commands are available.

Change-Id: I41b5668c855b2754a2e332cff4e90ebf2981aca0
  • Loading branch information
jingxu97 committed Feb 19, 2021
1 parent a8a56c4 commit c0201d4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions test/e2e/storage/testsuites/multivolume.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func (t *multiVolumeTestSuite) DefineTests(driver TestDriver, pattern testpatter
// [ node1 ] ==> [ node1 ]
// / \ <- same volume mode / \
// [volume1] [volume2] [volume1] [volume2]
ginkgo.It("should access to two volumes with the same volume mode and retain data across pod recreation on the same node", func() {
ginkgo.It("should access to two volumes with the same volume mode and retain data across pod recreation on the same node [LinuxOnly]", func() {
// Currently, multiple volumes are not generally available for pre-provisoined volume,
// because containerized storage servers, such as iSCSI and rbd, are just returning
// a static volume inside container, not actually creating a new volume per request.
Expand Down Expand Up @@ -157,7 +157,7 @@ func (t *multiVolumeTestSuite) DefineTests(driver TestDriver, pattern testpatter
// [ node1 ] ==> [ node2 ]
// / \ <- same volume mode / \
// [volume1] [volume2] [volume1] [volume2]
ginkgo.It("should access to two volumes with the same volume mode and retain data across pod recreation on different node", func() {
ginkgo.It("should access to two volumes with the same volume mode and retain data across pod recreation on different node [LinuxOnly]", func() {
// Currently, multiple volumes are not generally available for pre-provisoined volume,
// because containerized storage servers, such as iSCSI and rbd, are just returning
// a static volume inside container, not actually creating a new volume per request.
Expand Down Expand Up @@ -207,7 +207,7 @@ func (t *multiVolumeTestSuite) DefineTests(driver TestDriver, pattern testpatter
// [ node1 ] ==> [ node1 ]
// / \ <- different volume mode / \
// [volume1] [volume2] [volume1] [volume2]
ginkgo.It("should access to two volumes with different volume mode and retain data across pod recreation on the same node", func() {
ginkgo.It("should access to two volumes with different volume mode and retain data across pod recreation on the same node [LinuxOnly]", func() {
if pattern.VolMode == v1.PersistentVolumeFilesystem {
e2eskipper.Skipf("Filesystem volume case should be covered by block volume case -- skipping")
}
Expand Down Expand Up @@ -246,7 +246,7 @@ func (t *multiVolumeTestSuite) DefineTests(driver TestDriver, pattern testpatter
// [ node1 ] ==> [ node2 ]
// / \ <- different volume mode / \
// [volume1] [volume2] [volume1] [volume2]
ginkgo.It("should access to two volumes with different volume mode and retain data across pod recreation on different node", func() {
ginkgo.It("should access to two volumes with different volume mode and retain data across pod recreation on different node [LinuxOnly]", func() {
if pattern.VolMode == v1.PersistentVolumeFilesystem {
e2eskipper.Skipf("Filesystem volume case should be covered by block volume case -- skipping")
}
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/storage/testsuites/volumemode.go
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ func (t *volumeModeTestSuite) DefineTests(driver TestDriver, pattern testpattern

case testpatterns.DynamicPV:
if pattern.VolMode == v1.PersistentVolumeBlock && !isBlockSupported {
ginkgo.It("should fail in binding dynamic provisioned PV to PVC [Slow]", func() {
ginkgo.It("should fail in binding dynamic provisioned PV to PVC [Slow][LinuxOnly]", func() {
manualInit()
defer cleanup()

Expand Down Expand Up @@ -344,7 +344,7 @@ func (t *volumeModeTestSuite) DefineTests(driver TestDriver, pattern testpattern
framework.ExpectEqual(p.Status.Phase, v1.PodPending, "Pod phase isn't pending")
})

ginkgo.It("should not mount / map unused volumes in a pod", func() {
ginkgo.It("should not mount / map unused volumes in a pod [LinuxOnly]", func() {
if pattern.VolMode == v1.PersistentVolumeBlock {
skipTestIfBlockNotSupported(driver)
}
Expand Down

0 comments on commit c0201d4

Please sign in to comment.