Merge pull request kubernetes#118282 from wojtek-t/retry_after_followup

Follow up from dynamic retryAfter
openshift · Jun 5, 2023 · c07c739 · c07c739
2 parents 2901730 + d760439
commit c07c739
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/staging/src/k8s.io/apiserver/pkg/util/flowcontrol/dropped_requests_tracker.go b/staging/src/k8s.io/apiserver/pkg/util/flowcontrol/dropped_requests_tracker.go
@@ -111,7 +111,12 @@ func (s *droppedRequestsStats) updateHistory(unixTime int64, count int64) {
 	s.history = append(s.history, unixStat{unixTime: unixTime, requests: count})
 
 	startIndex := 0
-	for ; startIndex < len(s.history) && unixTime-s.history[startIndex].unixTime > maxRetryAfter; startIndex++ {
+	// Entries that exceed 2*retryAfter or maxRetryAfter are never going to be needed.
+	maxHistory := 2 * s.retryAfter.Load()
+	if maxHistory > maxRetryAfter {
+		maxHistory = maxRetryAfter
+	}
+	for ; startIndex < len(s.history) && unixTime-s.history[startIndex].unixTime > maxHistory; startIndex++ {
 	}
 	if startIndex > 0 {
 		s.history = s.history[startIndex:]
@@ -138,14 +143,12 @@ func (s *droppedRequestsStats) updateRetryAfterIfNeededLocked(unixTime int64) {
 	retryAfter := s.retryAfter.Load()
 
 	droppedRequests := int64(0)
-	if len(s.history) > 0 {
-		for i := len(s.history) - 1; i >= 0; i-- {
-			if unixTime-s.history[i].unixTime > retryAfter {
-				break
-			}
-			if s.history[i].unixTime < unixTime {
-				droppedRequests += s.history[i].requests
-			}
+	for i := len(s.history) - 1; i >= 0; i-- {
+		if unixTime-s.history[i].unixTime > retryAfter {
+			break
+		}
+		if s.history[i].unixTime < unixTime {
+			droppedRequests += s.history[i].requests
 		}
 	}
 

diff --git a/staging/src/k8s.io/apiserver/pkg/util/flowcontrol/dropped_requests_tracker_test.go b/staging/src/k8s.io/apiserver/pkg/util/flowcontrol/dropped_requests_tracker_test.go
@@ -63,7 +63,7 @@ func TestDroppedRequestsTracker(t *testing.T) {
 		}
 		fakeClock.Step(time.Duration(secondsToAdvance) * time.Second)
 
-		// Record only first dropped request and recompute retryAfter.
+		// Record all droppeded requests and recompute retryAfter.
 		for r := 0; r < step.droppedRequests; r++ {
 			tracker.RecordDroppedRequest("pl")
 		}