Skip to content

Commit

Permalink
Merge pull request #1957 from soltysh/revert_carry
Browse files Browse the repository at this point in the history
NO-JIRA: UPSTREAM: <carry>: Revert create readyz event for kubeapi server
  • Loading branch information
openshift-merge-bot[bot] committed Apr 25, 2024
2 parents 094c931 + f330449 commit d1ec84a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ ENV KUBE_BUILD_PLATFORMS=linux/arm64
ENV KUBE_STATIC_OVERRIDES=kube-apiserver
RUN make WHAT='cmd/kube-apiserver'

FROM registry.ci.openshift.org/ocp/4.16:base
FROM registry.ci.openshift.org/ocp/4.16:base-rhel9
COPY --from=macbuilder /go/src/k8s.io/kubernetes/_output/local/bin/darwin/amd64/kube-apiserver /usr/share/openshift/darwin/amd64/kube-apiserver
COPY --from=macarmbuilder /go/src/k8s.io/kubernetes/_output/local/bin/darwin/arm64/kube-apiserver /usr/share/openshift/darwin/arm64/kube-apiserver
COPY --from=linuxbuilder /go/src/k8s.io/kubernetes/_output/local/bin/linux/amd64/kube-apiserver /usr/share/openshift/linux/amd64/kube-apiserver
Expand Down
2 changes: 0 additions & 2 deletions staging/src/k8s.io/apiserver/pkg/server/healthz.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import (
"net/http"
"time"

corev1 "k8s.io/api/core/v1"
"k8s.io/apiserver/pkg/server/healthz"
"k8s.io/utils/clock"
)
Expand Down Expand Up @@ -107,7 +106,6 @@ func (s *GenericAPIServer) installReadyz() {
healthz.InstallReadyzHandlerWithHealthyFunc(s.Handler.NonGoRestfulMux, func() {
// note: InstallReadyzHandlerWithHealthyFunc guarantees that this is called only once
s.lifecycleSignals.HasBeenReady.Signal()
s.Eventf(corev1.EventTypeNormal, s.lifecycleSignals.HasBeenReady.Name(), "KubeAPIServer is ready")
}, s.readyzChecks...)
}

Expand Down

0 comments on commit d1ec84a

Please sign in to comment.