Skip to content

Commit

Permalink
UPSTREAM: <drop>: Revert "Merge pull request kubernetes#106306 from p…
Browse files Browse the repository at this point in the history
…awbana/change_bucketing_for_request_latency_metric"

This reverts commit b817efb, reversing
changes made to 5a81905.
  • Loading branch information
tkashem committed Jan 24, 2022
1 parent 112af52 commit de1d569
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 3 deletions.
4 changes: 2 additions & 2 deletions staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go
Expand Up @@ -102,8 +102,8 @@ var (
// This metric is used for verifying api call latencies SLO,
// as well as tracking regressions in this aspects.
// Thus we customize buckets significantly, to empower both usecases.
Buckets: []float64{0.05, 0.1, 0.2, 0.4, 0.6, 0.8, 1.0, 1.25, 1.5, 2, 3,
4, 5, 6, 8, 10, 15, 20, 30, 45, 60},
Buckets: []float64{0.05, 0.1, 0.15, 0.2, 0.25, 0.3, 0.35, 0.4, 0.45, 0.5, 0.6, 0.7, 0.8, 0.9, 1.0,
1.25, 1.5, 1.75, 2.0, 2.5, 3.0, 3.5, 4.0, 4.5, 5, 6, 7, 8, 9, 10, 15, 20, 25, 30, 40, 50, 60},
StabilityLevel: compbasemetrics.STABLE,
},
[]string{"verb", "dry_run", "group", "version", "resource", "subresource", "scope", "component"},
Expand Down
18 changes: 17 additions & 1 deletion test/instrumentation/testdata/stable-metrics-list.yaml
Expand Up @@ -211,24 +211,40 @@
buckets:
- 0.05
- 0.1
- 0.15
- 0.2
- 0.25
- 0.3
- 0.35
- 0.4
- 0.45
- 0.5
- 0.6
- 0.7
- 0.8
- 0.9
- 1
- 1.25
- 1.5
- 1.75
- 2
- 2.5
- 3
- 3.5
- 4
- 4.5
- 5
- 6
- 7
- 8
- 9
- 10
- 15
- 20
- 25
- 30
- 45
- 40
- 50
- 60
- name: apiserver_request_total
help: Counter of apiserver requests broken out for each verb, dry run value, group,
Expand Down

0 comments on commit de1d569

Please sign in to comment.