Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scc admission to wait for required SCCs #1006

Closed
wants to merge 1 commit into from

Conversation

deads2k
Copy link

@deads2k deads2k commented Oct 6, 2021

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 6, 2021
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2021
@openshift-ci-robot
Copy link

@deads2k: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Oct 6, 2021
@openshift-ci openshift-ci bot requested review from marun and mfojtik October 6, 2021 16:56
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2021
@openshift-ci-robot
Copy link

@deads2k: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@deads2k deads2k changed the title fakebump update scc admission to wait for required SCCs Oct 7, 2021
@deads2k
Copy link
Author

deads2k commented Oct 7, 2021

proof passed, real bump

/hold cancel

@deads2k
Copy link
Author

deads2k commented Oct 7, 2021

/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2021

@deads2k: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-cmd f9686b6 link false /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Oct 7, 2021
@deads2k
Copy link
Author

deads2k commented Oct 7, 2021

openshift/apiserver-library-go#64 was already lgtm'd reapplying here.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Author

deads2k commented Oct 7, 2021

#1008

@deads2k deads2k closed this Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants