Bug 2039373: UPSTREAM: 89885: SQUASH: Retry fetching clouds.conf #1107

mandre · 2022-01-11T15:59:22Z

The OpenStack secret is not guaranteed to be present at the time
kube-controller-manager is initialised.

openshift-ci · 2022-01-11T15:59:27Z

@mandre: This pull request references Bugzilla bug 2039373, which is invalid:

expected dependent Bugzilla bug 2004542 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2039373: UPSTREAM: 89885: SQUASH: Retry fetching clouds.conf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-01-11T15:59:32Z

@mandre: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

705f4d4|UPSTREAM: 89885: SQUASH: Retry fetching clouds.conf: the upstream PR kubernetes/kubernetes#89885 has not yet merged

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

mandre · 2022-01-12T13:37:56Z

/retest

mandre · 2022-01-13T10:48:57Z

/retest

soltysh · 2022-01-13T12:31:21Z

staging/src/k8s.io/legacy-cloud-providers/openstack/openstack.go

+		secret, err = os.secretLister.Secrets(os.secretNamespace).Get(os.secretName)
+		if err != nil {
+			klog.Infof("failed to get cloud.conf from secret (try %d), retrying after %d seconds. Error was: %v", i, i, err)
+			time.Sleep(time.Duration(i) * time.Second)


Same comment as #1099 (comment) applies

The OpenStack secret is not guaranteed to be present at the time kube-controller-manager is initialised. Co-authored-by: Martin André <m.andre@redhat.com> Co-authored-by: Pierre Prinetti <pierreprinetti@redhat.com>

openshift-ci-robot · 2022-01-18T09:00:40Z

@mandre: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

8ecc876|UPSTREAM: 89885: SQUASH: Retry fetching clouds.conf: the upstream PR kubernetes/kubernetes#89885 has not yet merged

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

mandre · 2022-01-24T12:58:14Z

/retest

mandre · 2022-01-27T16:16:17Z

/bugzilla refresh
/retest

openshift-ci · 2022-01-27T16:17:34Z

@mandre: This pull request references Bugzilla bug 2039373, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2004542 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2004542 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2022-01-28T11:07:49Z

This is a cherry-pick of #1099

soltysh

/lgtm
/approve
/label backport-risk-assesed
/remove-label backports/unvalidated-commits
/label backport/validated-commits

openshift-ci · 2022-01-28T15:33:43Z

@soltysh: The label(s) /label backport-risk-assesed , /label backport/validated-commits cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, backports/unvalidated-commits, backports/validated-commits, bugzilla/invalid-bug, bugzilla/valid-bug, cherry-pick-approved

In response to this:

/lgtm
/approve
/label backport-risk-assesed
/remove-label backports/unvalidated-commits
/label backport/validated-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-01-28T15:35:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

soltysh · 2022-02-01T12:17:08Z

/label backport-risk-assessed

eurijon · 2022-02-01T14:35:36Z

Hey @xingxingxia @duanwei33, as we are not QE approvers in this repo, would someone from your team be able to add the cherry-pick-approved label in this PR? We already verified it successfully in 4.10.
Thanks
/cc @xingxingxia
/cc @duanwei33

gangwgr · 2022-02-02T11:52:44Z

/label cherry-pick-approved

eurijon · 2022-02-02T13:48:46Z

/label cherry-pick-approved

thanks @gangwgr

openshift-bot · 2022-02-02T15:14:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-02-02T17:07:28Z

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-02-02T17:11:38Z

@mandre: All pull requests linked via external trackers have merged:

openshift/kubernetes#1107

Bugzilla bug 2039373 has been moved to the MODIFIED state.

In response to this:

Bug 2039373: UPSTREAM: 89885: SQUASH: Retry fetching clouds.conf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jan 11, 2022

openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 11, 2022

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 11, 2022

openshift-ci bot requested review from soltysh and sttts January 11, 2022 16:00

openshift-ci bot added the vendor-update Touching vendor dir or related files label Jan 11, 2022

soltysh requested changes Jan 13, 2022

View reviewed changes

UPSTREAM: 89885: SQUASH: Retry fetching clouds.conf

8ecc876

The OpenStack secret is not guaranteed to be present at the time kube-controller-manager is initialised. Co-authored-by: Martin André <m.andre@redhat.com> Co-authored-by: Pierre Prinetti <pierreprinetti@redhat.com>

mandre force-pushed the openstack-secret-race-49 branch from 705f4d4 to 8ecc876 Compare January 18, 2022 09:00

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 27, 2022

openshift-ci bot requested a review from eurijon January 27, 2022 16:17

soltysh approved these changes Jan 28, 2022

View reviewed changes

openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jan 28, 2022

openshift-ci bot assigned soltysh Jan 28, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2022

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 1, 2022

openshift-ci bot requested review from duanwei33 and xingxingxia February 1, 2022 14:35

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 2, 2022

openshift-merge-robot merged commit fc61f05 into openshift:release-4.9 Feb 2, 2022

mandre deleted the openstack-secret-race-49 branch February 3, 2022 09:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2039373: UPSTREAM: 89885: SQUASH: Retry fetching clouds.conf #1107

Bug 2039373: UPSTREAM: 89885: SQUASH: Retry fetching clouds.conf #1107

mandre commented Jan 11, 2022

openshift-ci bot commented Jan 11, 2022

openshift-ci-robot commented Jan 11, 2022

mandre commented Jan 12, 2022

mandre commented Jan 13, 2022

soltysh Jan 13, 2022

openshift-ci-robot commented Jan 18, 2022

mandre commented Jan 24, 2022

mandre commented Jan 27, 2022

openshift-ci bot commented Jan 27, 2022

pierreprinetti commented Jan 28, 2022

soltysh left a comment

openshift-ci bot commented Jan 28, 2022

openshift-ci bot commented Jan 28, 2022

soltysh commented Feb 1, 2022

eurijon commented Feb 1, 2022

gangwgr commented Feb 2, 2022

eurijon commented Feb 2, 2022

openshift-bot commented Feb 2, 2022

openshift-ci bot commented Feb 2, 2022

openshift-ci bot commented Feb 2, 2022

Bug 2039373: UPSTREAM: 89885: SQUASH: Retry fetching clouds.conf #1107

Bug 2039373: UPSTREAM: 89885: SQUASH: Retry fetching clouds.conf #1107

Conversation

mandre commented Jan 11, 2022

openshift-ci bot commented Jan 11, 2022

openshift-ci-robot commented Jan 11, 2022

mandre commented Jan 12, 2022

mandre commented Jan 13, 2022

soltysh Jan 13, 2022

Choose a reason for hiding this comment

openshift-ci-robot commented Jan 18, 2022

mandre commented Jan 24, 2022

mandre commented Jan 27, 2022

openshift-ci bot commented Jan 27, 2022

pierreprinetti commented Jan 28, 2022

soltysh left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jan 28, 2022

openshift-ci bot commented Jan 28, 2022

soltysh commented Feb 1, 2022

eurijon commented Feb 1, 2022

gangwgr commented Feb 2, 2022

eurijon commented Feb 2, 2022

openshift-bot commented Feb 2, 2022

openshift-ci bot commented Feb 2, 2022

openshift-ci bot commented Feb 2, 2022