WIP: azure-file: improve secret namespace discovery when translating to CSI #1147
Conversation
When translating InTree pv to CSI pv we use default secret namespace when it's not found in the InTree pv. Using the default so early is not ideal and can result in failed pod creation after users migrate to cluster with CSI enabled because the existing pvs might not have the namespace defined. There is another object we can use to determine correct namespace which presence could be safely assumed - ClaimRef. Using default namespace should never happen however should be safe for cases when secret is not needed - e.g. unmounting a volume.
There is no reason to assign default namespace value and then rewrite it based on other conditions. Separate namespace logic so the code is easier to read.
This is the actual fix - attempt to obtain a namespace from ClaimRef, if present.
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@RomanBednar: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RomanBednar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@RomanBednar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.