Always check connectivity to overlay network #1158
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@michalskalski: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: michalskalski The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @michalskalski. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-ok-to-test
| @@ -93,54 +73,28 @@ func (c *aggregatedAPIServiceAvailabilityCheck) checkForConnection(context gener | |||
| }, | |||
| Timeout: 1 * time.Second, // these should all be very fast. if none work, we continue anyway. | |||
There was a problem hiding this comment.
1 second is tooo short in production environments
There was a problem hiding this comment.
Hi, part of the code which do a http request is not changed, the 1 second value is used in current releases, should that be changed in your opinion?
There was a problem hiding this comment.
yeah, I just noticed now, forget the comment, I really NOT understand it well
When kube-apiserver is no longer able connect overlay network where oAuth PODs resides it still remains active, but cannot properly handle requests. In that case kube-apiserver should be marked as not ready by one of the readyz checks. Current checks only verify connectivy once after kube-apiserver started. Modify checks to constantly monitor connection to overlay network.
michalskalski
force-pushed
the
pod_net_connectivity
branch
from
919050d
to
3965bae
Compare
|
@michalskalski: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Initial issue was solved by extending list of resources for which connectivity to aggregated api is not required openshift/library-go@5add9e2 |
When kube-apiserver is no longer able connect overlay network
where oAuth PODs resides it still remains active, but cannot
properly handle requests. In that case kube-apiserver should
be marked as not ready by one of the readyz checks.
Current checks only verify connectivy once after
kube-apiserver started. Modify checks to constantly monitor
connection to overlay network.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: