Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove svc from registry as it no longer works #1159

Closed
wants to merge 1 commit into from
Closed

remove svc from registry as it no longer works #1159

wants to merge 1 commit into from

Conversation

jluhrsen
Copy link

s/registry.svc.ci.openshift.org/registry.ci.openshift.org

Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jan 31, 2022
@openshift-ci-robot
Copy link

@jluhrsen: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mfojtik and sttts January 31, 2022 22:21
@openshift-ci-robot
Copy link

@jluhrsen: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@jluhrsen
Copy link
Author

/validate-backports

@openshift-ci-robot
Copy link

@jluhrsen: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@jluhrsen
Copy link
Author

jluhrsen commented Feb 1, 2022

/retest

@jluhrsen
Copy link
Author

jluhrsen commented Feb 2, 2022

/assign @soltysh

@openshift-ci-robot
Copy link

@jluhrsen: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@jluhrsen: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jluhrsen
To complete the pull request process, please ask for approval from soltysh after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jluhrsen
UPSTREAM: <drop>: remove svc from registry...
9266303 
...as it no longer works

s/registry.svc.ci.openshift.org/registry.ci.openshift.org

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@openshift-ci-robot
Copy link

@jluhrsen: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@jluhrsen
Copy link
Author

jluhrsen commented Feb 4, 2022

/retest

@jluhrsen
Copy link
Author

jluhrsen commented Mar 9, 2022

/retest-required

@jluhrsen
Copy link
Author

/assign @deads2k

@jluhrsen
Copy link
Author

/assign @sttts

@jluhrsen
Copy link
Author

/assign @mfojtik

@jluhrsen
Copy link
Author

jluhrsen commented Apr 4, 2022

/assign @marun

@openshift-ci
Copy link

openshift-ci bot commented May 31, 2022

@jluhrsen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-upgrade-from-stable-4.10-images 9266303 link true /test 4.11-upgrade-from-stable-4.10-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 31, 2022

@jluhrsen: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jluhrsen jluhrsen closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sttts sttts Awaiting requested review from sttts

Assignees

@marun marun

@soltysh soltysh

@sttts sttts

@deads2k deads2k

Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jluhrsen @openshift-ci-robot @marun @soltysh @sttts @deads2k