Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2050247: UPSTREAM: 107902: Merge pull request #107902 from xueqzhan/automated-… #1167

Merged
merged 1 commit into from Feb 4, 2022
Merged

Bug 2050247: UPSTREAM: 107902: Merge pull request #107902 from xueqzhan/automated-… #1167

merged 1 commit into from Feb 4, 2022

Conversation

xueqzhan
Copy link

@xueqzhan xueqzhan commented Feb 2, 2022

…cherry-pick-of-kubernetes#107786-upstream-release-1.23

Automated cherry pick of kubernetes#107786: Revert "Fix comparison between FQDN and hostname"

What type of PR is this?
/kind bug

What this PR does / why we need it:
This reverts a bug commit.

We do not have guarantee that the agnhost's /hostname endpoint returns
a hostname and not an FQDN. We also do not have guarantee a hostname
gets passed to the execHostnameTest() function for comparison.

So make sure we're comparing hostnames in execHostnameTest().

Fixes #

@k8s-ci-robot @xueqzhan
UPSTREAM: 107902: Merge pull request kubernetes#107902 from xueqzhan/…
0a5757a 
…automated-cherry-pick-of-#107786-upstream-release-1.23

Automated cherry pick of kubernetes#107786: Revert "Fix comparison between FQDN and hostname"
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2022

@xueqzhan: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

UPSTREAM: 107902: Merge pull request kubernetes#107902 from xueqzhan/automated-…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 2, 2022
@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Feb 2, 2022
@openshift-ci-robot
Copy link

@xueqzhan: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mfojtik and sttts February 2, 2022 22:34
@xueqzhan xueqzhan changed the title UPSTREAM: 107902: Merge pull request #107902 from xueqzhan/automated-… Bug 2050247: UPSTREAM: 107902: Merge pull request #107902 from xueqzhan/automated-… Feb 3, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Feb 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

@xueqzhan: This pull request references Bugzilla bug 2050247, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "4.10.z" instead
  • expected dependent Bugzilla bug 2044824 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2050247: UPSTREAM: 107902: Merge pull request kubernetes#107902 from xueqzhan/automated-…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 3, 2022
@xueqzhan
Copy link
Author

xueqzhan commented Feb 3, 2022

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

@xueqzhan: This pull request references Bugzilla bug 2050247, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "4.10.z" instead
  • expected dependent Bugzilla bug 2044824 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xueqzhan
Copy link
Author

xueqzhan commented Feb 3, 2022

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

@xueqzhan: This pull request references Bugzilla bug 2050247, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected dependent Bugzilla bug 2044824 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xueqzhan
Copy link
Author

xueqzhan commented Feb 3, 2022

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

@xueqzhan: This pull request references Bugzilla bug 2050247, which is invalid:

  • expected Bugzilla bug 2050247 to depend on a bug targeting a release in 4.11.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link

deads2k commented Feb 3, 2022

/lgtm
/approve

you must get your BZ right or the bot will never allow this to merge.

@deads2k deads2k added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). labels Feb 3, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2022
@dgoodwin dgoodwin mentioned this pull request Feb 3, 2022
Merged
@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2022
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@xueqzhan
Copy link
Author

xueqzhan commented Feb 3, 2022

/retest

@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link

openshift-ci bot commented Feb 4, 2022

@openshift-bot: This pull request references Bugzilla bug 2050247, which is invalid:

  • expected dependent Bugzilla bug 2044824 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xueqzhan
Copy link
Author

xueqzhan commented Feb 4, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 4, 2022

@xueqzhan: This pull request references Bugzilla bug 2050247, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2044824 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2044824 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from eurijon February 4, 2022 19:09
@xueqzhan
Copy link
Author

xueqzhan commented Feb 4, 2022

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Feb 4, 2022

@xueqzhan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d99c04f into openshift:release-4.10 Feb 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 4, 2022

@xueqzhan: All pull requests linked via external trackers have merged:

Bugzilla bug 2050247 has been moved to the MODIFIED state.

In response to this:

Bug 2050247: UPSTREAM: 107902: Merge pull request kubernetes#107902 from xueqzhan/automated-…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xueqzhan added a commit to xueqzhan/origin that referenced this pull request Feb 5, 2022
@xueqzhan
Bug 2050247 Update k8s vendoring
85d7788 
This change imports openshift/kubernetes#1167
into Origin.

Generated with:
```
./hack/update-kube-vendor.sh d99c04f73e7477c8ea1dbfc676dae390f7b890dd
./hack/update-generated.sh
```
@xueqzhan xueqzhan mentioned this pull request Feb 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sttts sttts Awaiting requested review from sttts

@eurijon eurijon Awaiting requested review from eurijon

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xueqzhan @openshift-ci-robot @deads2k @openshift-bot @openshift-merge-robot @k8s-ci-robot