Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2055687: UPSTREAM: 108132: Fix incorrect parameters in EndpointsEqualBeyondHash #1185

Closed
wants to merge 1 commit into from

Conversation

aojea
Copy link

@aojea aojea commented Feb 17, 2022

The endpoint slice controller does not compare correctly the fields
NodeName and Zone on the Endpoint Slices, causing that changes on those
fields only, doesn't trigger an update.

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 17, 2022
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Feb 17, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 17, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 17, 2022

@aojea: This pull request references Bugzilla bug 2055687, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2055687: UPSTREAM: 108123: Fix incorrect parameters in EndpointsEqualBeyondHash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@aojea: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@aojea
Copy link
Author

aojea commented Feb 17, 2022

/assign @soltysh

…qualBeyondHash

The endpoint slice controller does not compare correctly the fields
NodeName and Zone on the Endpoint Slices, causing that changes on those
fields only, doesn't trigger an update.
@openshift-ci-robot
Copy link

@aojea: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mfojtik and sttts February 17, 2022 14:23
@openshift-ci
Copy link

openshift-ci bot commented Feb 17, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aojea
To complete the pull request process, please ask for approval from soltysh after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aojea aojea changed the title Bug 2055687: UPSTREAM: 108123: Fix incorrect parameters in EndpointsEqualBeyondHash Bug 2055687: UPSTREAM: 108132: Fix incorrect parameters in EndpointsEqualBeyondHash Feb 17, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 17, 2022

@aojea: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-cgroupsv2 cd1ae98 link false /test e2e-aws-cgroupsv2
ci/prow/e2e-aws-fips cd1ae98 link true /test e2e-aws-fips
ci/prow/verify-commits cd1ae98 link true /test verify-commits
ci/prow/e2e-agnostic-cmd cd1ae98 link false /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Member

soltysh commented Mar 1, 2022

@aojea I'd suggest we pick this up when upstream PR merges and we'll get it for free during next k8s bump, given this is only a medium prio BZ. Objections?

@aojea
Copy link
Author

aojea commented Mar 1, 2022

@aojea I'd suggest we pick this up when upstream PR merges and we'll get it for free during next k8s bump, given this is only a medium prio BZ. Objections?

Agree, I thought it was a bigger problem

@aojea aojea closed this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants