New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2055687: UPSTREAM: 108132: Fix incorrect parameters in EndpointsEqualBeyondHash #1185
Conversation
@aojea: This pull request references Bugzilla bug 2055687, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@aojea: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
/assign @soltysh |
…qualBeyondHash The endpoint slice controller does not compare correctly the fields NodeName and Zone on the Endpoint Slices, causing that changes on those fields only, doesn't trigger an update.
9d82f8a
to
cd1ae98
Compare
@aojea: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@aojea: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@aojea I'd suggest we pick this up when upstream PR merges and we'll get it for free during next k8s bump, given this is only a medium prio BZ. Objections? |
Agree, I thought it was a bigger problem |
The endpoint slice controller does not compare correctly the fields
NodeName and Zone on the Endpoint Slices, causing that changes on those
fields only, doesn't trigger an update.
/kind bug