Bug 2069310: UPSTREAM: <carry>: use hardcoded rest mapper from library-go

[tkashem]

No description provided.

[openshift-ci-robot]

@tkashem: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• aabcee3|UPSTREAM: : use hardcoded rest mapper from library-go: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci]

@tkashem: This pull request references Bugzilla bug 2069310, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2069310: UPSTREAM: : use hardcoded rest mapper from library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tkashem]

1. If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.
   • verified
   • does not apply
2. The bug has significant impact either through severity, reduction in supportability, or number of users affected.
   • verified
   • does not apply
3. For branches that are in the Maintenance lifecycle phase:
   • The bug is a critical fix, no reasonable workaround exists, and a recommendation for upgrade has been ruled out, or
   • The bug is a security related bug
   • Branch not in maintenance mode yet (current release + previous release for 90 days after current GA; everything older is in maintenance)
4. The severity field of the bug must be set to accurately reflect criticality.
   • verified
5. The PR was created with the cherry-pick bot OR the PR’s description is well formed with user-focused release notes that state the bug number, impact, cause, and resolution. Where appropriate, it should also contain information about how a user can identify whether a particular cluster is affected.
   • verified

[tkashem]

/label backport-risk-assessed

[tkashem]

/bugzilla refresh

[openshift-ci]

@tkashem: This pull request references Bugzilla bug 2069310, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2069311 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2069311 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
• bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tkashem]

/retest

[tkashem]

/retest

[tkashem]

/retest

[tkashem]

/retest

[aojea]

@sosiouxme is 4.9 using golang 1.17 or 1.18 without the ENV variable hack ?

[aojea]

is it possible that the builder image doesn't have the correct go version? the patch seems to be there

kubernetes/openshift-hack/images/hyperkube/Dockerfile.rhel

Lines 1 to 9 in a36406b

	FROM registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.16-openshift-4.9 AS builder
	WORKDIR /go/src/k8s.io/kubernetes
	COPY . .
	RUN make GOFLAGS='-mod=vendor -p=4 -tags=unsupportedGolang116OnlyUseDeprecatedParseIPv4' \
	WHAT='cmd/kube-apiserver cmd/kube-controller-manager cmd/kube-scheduler cmd/kubelet cmd/watch-termination' && \
	mkdir -p /tmp/build && \
	cp openshift-hack/images/hyperkube/hyperkube /tmp/build && \
	cp /go/src/k8s.io/kubernetes/_output/local/bin/linux/$(go env GOARCH)/{kube-apiserver,kube-controller-manager,kube-scheduler,kubelet,watch-termination} \
	/tmp/build

[sosiouxme]

is it possible that the builder image doesn't have the correct go version? the patch seems to be there

🐚 podman run -it registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.16-openshift-4.9 go version
go version go1.16.12 linux/amd64

that's the updated version which I built that should have the patch using the build flag. I didn't know a good way to test that it was correctly allowing the deprecated format, so I was relying on the unit tests to tell us...

[tkashem]

/retest

[tkashem]

/assign @deads2k

[deads2k]

/approve

[p0lyn0mial]

since this is a backport I trust that we already checked and tested the new mapper.

[p0lyn0mial]

okay, this points to https://github.com/openshift/library-go/commits/release-4.9

[p0lyn0mial]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, p0lyn0mial, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wangke19]

/label cherry-pick-approved

[tkashem]

/remove-label backports/unvalidated-commits
/label backports/validated-commits

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[tkashem]

/retest

[openshift-ci]

@tkashem: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@tkashem: All pull requests linked via external trackers have merged:

• openshift/kubernetes#1233
• openshift/library-go#1339

Bugzilla bug 2069310 has been moved to the MODIFIED state.

In response to this:

Bug 2069310: UPSTREAM: : use hardcoded rest mapper from library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.