Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2073153: golang toolchain unsupported parsers tag #1239

Merged
merged 1 commit into from Apr 13, 2022
Merged

Bug 2073153: golang toolchain unsupported parsers tag #1239

merged 1 commit into from Apr 13, 2022

Conversation

aojea
Copy link

@aojea aojea commented Apr 12, 2022 •
edited

When adding the test to verify the IPs with leading zeros, #1173

only the Dockerfile that builds the apiserver images was modified, but it turns out that we have to pass those tags to the golang version used to run the tests

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 12, 2022
@openshift-ci-robot
Copy link

@aojea: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2022

@aojea: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

golang toolchain unsupporrted parsers tag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from soltysh and sttts April 12, 2022 14:57
@openshift-ci-robot
Copy link

@aojea: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@sanchezl
Copy link

/retest

@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2022

@aojea: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

golang toolchain unsupporrted parsers tag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2022

@aojea: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

golang toolchain unsupporrted parsers tag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Author

aojea commented Apr 12, 2022

this is working 👯

@sosiouxme sosiouxme changed the title golang toolchain unsupporrted parsers tag Bug 2073153: golang toolchain unsupported parsers tag Apr 12, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 12, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2022

@aojea: This pull request references Bugzilla bug 2073153, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2042493 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2042493 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 2073153: golang toolchain unsupported parsers tag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from wangke19 April 12, 2022 16:33
@aojea
UPSTREAM: <carry>: golang toolchain unsupported parsers
eb63cd3 
The RH golang toolchain has backported the strict parsers for IP
addresses, but Openshift can't invalidate that that was previously
valid, hence the golang team added a tag to keep the loose parsers

Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
@openshift-ci-robot
Copy link

@aojea: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

soltysh
soltysh approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Apr 12, 2022
@soltysh
Copy link
Member

soltysh commented Apr 12, 2022

/test unit

@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 12, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, sanchezl, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Member

soltysh commented Apr 13, 2022

The failures are not related with this change
/overrride ci/prow/e2e-agnostic-cmd
/override ci/prow/e2e-aws-csi

@openshift-ci
Copy link

openshift-ci bot commented Apr 13, 2022

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-csi

In response to this:

The failures are not related with this change
/overrride ci/prow/e2e-agnostic-cmd
/override ci/prow/e2e-aws-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Apr 13, 2022

@aojea: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-cmd eb63cd3 link false /test e2e-agnostic-cmd
ci/prow/e2e-aws-csi eb63cd3 link false /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Member

soltysh commented Apr 13, 2022

/overrride ci/prow/e2e-agnostic-cmd
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 13, 2022
@soltysh
Copy link
Member

soltysh commented Apr 13, 2022

Manually applying cherry-pick-approved label, since this is purely unit and integration test change coming from golang changes introduced in newer go1.16 versions.

@soltysh soltysh added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 13, 2022
@openshift-merge-robot openshift-merge-robot merged commit 69ded02 into openshift:release-4.9 Apr 13, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 13, 2022

@aojea: All pull requests linked via external trackers have merged:

Bugzilla bug 2073153 has been moved to the MODIFIED state.

In response to this:

Bug 2073153: golang toolchain unsupported parsers tag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh mentioned this pull request Apr 13, 2022
Merged
@aojea
Copy link
Author

aojea commented Apr 13, 2022

/cherry-pick release-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 13, 2022
Merged
@openshift-cherrypick-robot
Copy link

@aojea: new pull request created: #1240

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sosiouxme added a commit to sosiouxme/kubernetes that referenced this pull request Apr 13, 2022
@sosiouxme
UPSTREAM: <carry>: hyperkube Dockerfile/tests: add deprecated parser …
20884ae 
…build flag

ref https://issues.redhat.com/browse/ART-3664
incorporates followup PR openshift#1239
locriandev pushed a commit to locriandev/kubernetes that referenced this pull request May 2, 2022
@sosiouxme @locriandev
UPSTREAM: <carry>: hyperkube Dockerfile/tests: add deprecated parser …
4ad5cc0 
…build flag

ref https://issues.redhat.com/browse/ART-3664
incorporates followup PR openshift#1239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@sanchezl sanchezl sanchezl approved these changes

@sttts sttts Awaiting requested review from sttts

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@soltysh soltysh

@kasturinarra kasturinarra

@zhouying7780 zhouying7780

@xingxingxia xingxingxia

@sunilcio sunilcio

@duanwei33 duanwei33

@wangke19 wangke19

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet