UPSTREAM <90175>: pkg/proxy: add last-queued-timestamp metric #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doens't have CI, so we'll need to get someone to push the green button when everything looks sane. |
mfojtik
force-pushed
the
sdn-4.5-kubernetes-1.18.2
branch
from
ad077cd
to
d411faf
Compare
|
needs rebase now to get rid of the commits from the old 1.18.2 branch. |
This adds a metric, kubeproxy_sync_proxy_rules_last_queued_timestamp, that captures the last time a change was queued to be applied to the proxy. This matches the healthz logic, which fails if a pending change is stale. This allows us to write alerts that mirror healthz. Signed-off-by: Casey Callendrello <cdc@redhat.com>
squeed
force-pushed
the
backport-sdn-metric
branch
from
852c8a7
to
6022863
Compare
|
rebased. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a metric, kubeproxy_sync_proxy_rules_last_queued_timestamp, that captures the last time a change was queued to be applied to the proxy. This matches the healthz logic, which fails if a pending change is stale.
This allows us to write alerts that mirror healthz.
Signed-off-by: Casey Callendrello cdc@redhat.com
/cc @dcbw who merged the upstream change.