Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdn 4.11 kubernetes 1.24 #1270

Conversation

bpickard22
Copy link

PR for openshift-sdn 1.24 rebase

danwinship and others added 4 commits May 23, 2022 16:57
This commit fixes bug 1919737.

https://bugzilla.redhat.com/show_bug.cgi?id=1919737

* pkg/proxy/iptables/proxier.go (syncProxyRules): Prefer a local endpoint
for the cluster DNS service.

(cherry picked from commit 54dc362)
…olicy

If a service has a
"traffic-policy.network.alpha.openshift.io/local-with-fallback"
annotation, then only treat it as "externalTrafficPolicy: Local" when
there are actually running local pods.

That is, if we receive traffic for such a service after the last local
pod terminates, then forward it to a remote pod rather than dropping
it.

(cherry picked from commit 0a5c66b)
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 23, 2022
@openshift-ci-robot
Copy link

@bpickard22: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh May 23, 2022 22:41
@openshift-ci
Copy link

openshift-ci bot commented May 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bpickard22
To complete the pull request process, please assign soltysh after the PR has been reviewed.
You can assign the PR to them by writing /assign @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label May 23, 2022
Copy link

@openshift-ci openshift-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpickard22: 1 invalid DOWNSTREAM_OWNERS file

In response to this:

PR for openshift-sdn 1.24 rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

DOWNSTREAM_OWNERS Outdated Show resolved Hide resolved
Instead, add a method so openshift-sdn can force a full reload only
when it really needs to.

(cherry picked from commit 712d3c9)
@openshift-ci-robot
Copy link

@bpickard22: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

Copy link

@openshift-ci openshift-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpickard22: 1 invalid DOWNSTREAM_OWNERS file

In response to this:

PR for openshift-sdn 1.24 rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

DOWNSTREAM_OWNERS Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link

@bpickard22: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label May 24, 2022
@mrunalp
Copy link
Member

mrunalp commented May 24, 2022

Could you clean up the commits? First and last one are touching the same file.

@bpickard22 bpickard22 closed this May 24, 2022
@bpickard22 bpickard22 deleted the sdn-4.11-kubernetes-1.24 branch May 24, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants