Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 110255: Endpoints and EndpointSlices should not publish IPs… #1279

Closed
wants to merge 2 commits into from

Conversation

aojea
Copy link

@aojea aojea commented Jun 1, 2022

@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Jun 1, 2022
@openshift-ci-robot
Copy link

@aojea: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2022
@openshift-ci openshift-ci bot requested review from sjenning and soltysh June 1, 2022 14:18
@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aojea
To complete the pull request process, please assign mfojtik after the PR has been reviewed.
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. and removed backports/validated-commits Indicates that all commits come to merged upstream PRs. labels Jun 1, 2022
@openshift-ci-robot
Copy link

@aojea: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2022
@aojea
Copy link
Author

aojea commented Jun 1, 2022

/hold

cherry pick have some conflicts, I have to figure them out

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2022

@aojea: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/k8s-e2e-gcp 3207564 link true /test k8s-e2e-gcp
ci/prow/e2e-gcp 3207564 link true /test e2e-gcp
ci/prow/e2e-aws-fips 3207564 link true /test e2e-aws-fips
ci/prow/verify 3207564 link true /test verify
ci/prow/e2e-aws-cgroupsv2 3207564 link false /test e2e-aws-cgroupsv2
ci/prow/e2e-agnostic-cmd 3207564 link false /test e2e-agnostic-cmd
ci/prow/k8s-e2e-gcp-serial 3207564 link true /test k8s-e2e-gcp-serial
ci/prow/e2e-aws-crun 3207564 link true /test e2e-aws-crun
ci/prow/verify-commits 3207564 link true /test verify-commits
ci/prow/e2e-aws-serial 3207564 link true /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aojea
Copy link
Author

aojea commented Jun 4, 2022

superseded by #1282

@aojea aojea closed this Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants