WIP: Fix iSCSI over ipv6 #1292
Closed
WIP: Fix iSCSI over ipv6 #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create (POST) custom resources should be scope:resource
…pifield-comment cleanup: modify the comments of NodeInclusionPolicy
…cking Cleanup no-longer used storage cleanup method
Signed-off-by: Monis Khan <mok@vmware.com>
…stats kubelet/stats: update cadvisor stats provider with new log location
don't skip Feature:EphemeralStorage based on skipper
Given kubeadm 1.25 only supports kubelet 1.25 and 1.24, 1.23 related logic around dockershim can be removed. - Don't clean the directories /var/lib/dockershim, /var/runkubernetes, /var/lib/cni - Pass the CRISocket directly to the kubelet --container-runtime-endpoint flag without extra handling of dockershim - No longer apply the --container-runtime=remote flag as that is the only possible value in 1.24 and 1.25 - Update unit tests Note: we are still passing --pod-infra-container-image to avoid the pause image to be GCed by the kubelet.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
…-histograms Wrap weighted histograms
…late-versioner storage: move the APIObjectVersioner definition to storage
Fix requests scope classification
…late-continue storage: move continue token definition to storage
…auth_plugins Remove gcp and azure auth plugins
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Use typed ImageID for imageutils images
…et-flags-without-dockershim kubeadm: perform dockershim cleanup for 1.25
Minor cleanups in integration test shutdown
do not install docker with curl
…atch-comments Cleanup: modify unmatch comments with stopCh
Our tests are mostly error based and explicit error typing allows us to test against error types directly. Having made this change also makes it obvious that our test coverage was lacking in two branches, specifically, we were previously not testing empty start keys nor were we testing for invalid start RVs.
…omote remove deprecated metric and promote the replacement to STABLE
…o-registry.k8s.io Move from k8s.gcr.io to registry.k8s.io
add explicit typing for continue tests
…ryConfigFix fix the registry configuration
openshift-ci-robot
added
the
backports/unvalidated-commits
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@jsafrane: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-rebase
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
openshift-ci
bot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Addresses in the Kubernetes API objects (PV, Pod) have `[]` around IPv6 addresses, while addresses in /dev/ and /sys/ have addresses without them. Add/remove `[]` as needed.
|
/close |
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
openshift-ci
bot
added
the
needs-rebase
|
@jsafrane: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jsafrane: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jsafrane: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses in the Kubernetes API objects (PV, Pod) have
[]around IPv6addresses, while addresses in /dev/ and /sys/ have addresses without them.
Add/remove
[]as needed.WIP: testing in OCP before sending to Kubernetes