Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.9] Bug 2105663: UPSTREAM: <carry>: update list of deprecated apis #1316

Merged

Conversation

sanchezl
Copy link

@sanchezl sanchezl commented Jul 9, 2022

Cherry-pick of #1091

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jul 9, 2022
@openshift-ci-robot
Copy link

@sanchezl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 9, 2022

@sanchezl: This pull request references Bugzilla bug 2105663, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2103381 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2103381 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

[release 4.9] Bug 2105663: UPSTREAM: : update list of deprecated apis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from wangke19, deads2k and sttts July 9, 2022 13:44
@openshift-ci
Copy link

openshift-ci bot commented Jul 9, 2022

@sanchezl: This pull request references Bugzilla bug 2105663, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2103381 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2103381 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

[release 4.9] Bug 2105663: UPSTREAM: : update list of deprecated apis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanchezl
Copy link
Author

sanchezl commented Jul 9, 2022

  1. If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.
    • verified
    • does not apply
  2. The bug has significant impact either through severity, reduction in supportability, or number of users affected.
    • verified
    • does not apply
  3. For branches that are in the Maintenance lifecycle phase:
    • The bug is a critical fix, no reasonable workaround exists, and a recommendation for upgrade has been ruled out, or
    • The bug is a security related bug
    • Branch not in maintenance mode yet (current release + previous release for 90 days after current GA; everything older is in maintenance)
  4. The severity field of the bug must be set to accurately reflect criticality.
    • verified
  5. The PR was created with the cherry-pick bot OR the PR’s description is well formed with user-focused release notes that state the bug number, impact, cause, and resolution. Where appropriate, it should also contain information about how a user can identify whether a particular cluster is affected.
    • verified

@sanchezl sanchezl changed the title [release 4.9] Bug 2105663: UPSTREAM: <carry>: update list of deprecated apis [release-4.9] Bug 2105663: UPSTREAM: <carry>: update list of deprecated apis Jul 9, 2022
@sanchezl
Copy link
Author

/retest

1 similar comment
@sanchezl
Copy link
Author

/retest

@zimo-xiao
Copy link

/bugzilla cc-qa

@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2022

@zimo-xiao: This pull request references Bugzilla bug 2105663, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2103381 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2103381 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @zxiao-redhat

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zxiao-redhat July 11, 2022 03:56
@tkashem
Copy link

tkashem commented Jul 11, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2022
@tkashem
Copy link

tkashem commented Jul 11, 2022

/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Jul 11, 2022
@tkashem
Copy link

tkashem commented Jul 11, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 11, 2022
@sdodson sdodson added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 11, 2022
@sdodson
Copy link
Member

sdodson commented Jul 11, 2022

Moving this along quickly because these changes need to make it to 4.8 before people stop upgrading to the latest 4.8.z.

@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sanchezl, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD f34b40c and 8 for PR HEAD 1365f69 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD f34b40c and 7 for PR HEAD 1365f69 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f34b40c and 6 for PR HEAD 1365f69 in total

@sdodson
Copy link
Member

sdodson commented Jul 11, 2022

/retest-required

@gangwgr
Copy link

gangwgr commented Jul 12, 2022

/label cherry-pick-approved

1 similar comment
@gangwgr
Copy link

gangwgr commented Jul 12, 2022

/label cherry-pick-approved

@sanchezl
Copy link
Author

/retest-required

@sdodson
Copy link
Member

sdodson commented Jul 13, 2022

/retest-required
now that the image stream stuff has been disabled in tests

@sanchezl
Copy link
Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 9c3ffbb and 5 for PR HEAD 1365f69 in total

@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2022

@sanchezl: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 3ecd16b into openshift:release-4.9 Jul 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2022

@sanchezl: All pull requests linked via external trackers have merged:

Bugzilla bug 2105663 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2105663: UPSTREAM: : update list of deprecated apis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet