Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2113977: UPSTREAM: 110670: Fix pod stuck in termination state when mount fails… #1336

Closed
wants to merge 1 commit into from

Conversation

rphillips
Copy link

@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Aug 2, 2022
@openshift-ci-robot
Copy link

@rphillips: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@rphillips rphillips changed the title UPSTREAM: 110670: Fix pod stuck in termination state when mount fails… Bug 2113977: UPSTREAM: 110670: Fix pod stuck in termination state when mount fails… Aug 2, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

@rphillips: This pull request references Bugzilla bug 2113977, which is invalid:

  • expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2113977: UPSTREAM: 110670: Fix pod stuck in termination state when mount fails…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from mfojtik and sjenning August 2, 2022 13:18
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rphillips
Once this PR has been reviewed and has the lgtm label, please assign mfojtik for approval by writing /assign @mfojtik in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips
Copy link
Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

@rphillips: This pull request references Bugzilla bug 2113977, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Author

/cherry-pick release-4.11

@openshift-cherrypick-robot

@rphillips: once the present PR merges, I will cherry-pick it on top of release-4.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Author

/retest

1 similar comment
@rphillips
Copy link
Author

/retest

@rphillips
Copy link
Author

/retest-required

@rphillips
Copy link
Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2022

@rphillips: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/k8s-e2e-gcp 094e05c link true /test k8s-e2e-gcp
ci/prow/k8s-e2e-conformance-aws 094e05c link true /test k8s-e2e-conformance-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rphillips rphillips closed this Aug 5, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2022

@rphillips: This pull request references Bugzilla bug 2113977. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.
Warning: Failed to comment on Bugzilla bug with reason for changed state.

In response to this:

Bug 2113977: UPSTREAM: 110670: Fix pod stuck in termination state when mount fails…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member

gnufied commented Aug 18, 2022

@rphillips why did you close this PR btw?

@swghosh
Copy link
Member

swghosh commented Sep 14, 2022

This was closed as it should land as a part of rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants