New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: <carry>: Dockerfile: use centos:stream9 #1366
UPSTREAM: <carry>: Dockerfile: use centos:stream9 #1366
Conversation
@kikisdeliveryservice: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
openshift-hack/images/os/Dockerfile
Outdated
# fedora:29 is an image built within the release scripts: | ||
# https://github.com/openshift/release/blob/b45a09d248b8cdb8fe3bf5f3cfa0b4fee57d04c8/ci-operator/config/openshift/kubernetes/openshift-kubernetes-release-4.10.yaml#L63-L65 | ||
FROM fedora:29 AS build | ||
FROM centos:stream9 AS build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be FROM quay.io/centos/centos:stream9 as build
. The images on the Docker hub seem not to be updated for CentOS Stream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll give it a try!
e293931
to
60330b8
Compare
@kikisdeliveryservice: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
arrgh: need to change to: |
@kikisdeliveryservice: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
Really weird that this is also hitting some of same errors as #1360 |
some changes in ocp/release trying again |
609b1f2
to
60330b8
Compare
@kikisdeliveryservice: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
60330b8
to
7a21246
Compare
@kikisdeliveryservice: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/remove-label backports/unvalidated-commits
/label backports/validated-commits
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/test e2e-gcp-upgrade |
To prevent the bot from chasing with us I've opened openshift/release#32444 and I'm overriding the failed jobs which failed due to missing |
@soltysh: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/e2e-aws-crun |
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-crun, ci/prow/e2e-aws-serial, ci/prow/e2e-gcp-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/e2e-aws-csi |
@soltysh: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kikisdeliveryservice: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Our repo is currently using Fedora 29 which is EOL and started to fail pulling images during our rebase work. We need to using centos:stream9 both to have current os and also to succesfully build machine-os-content for k8s rebase w/ 1.25