Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: <carry>: Dockerfile: use centos:stream9 #1366

Merged

Conversation

kikisdeliveryservice
Copy link

@kikisdeliveryservice kikisdeliveryservice commented Sep 16, 2022

Our repo is currently using Fedora 29 which is EOL and started to fail pulling images during our rebase work. We need to using centos:stream9 both to have current os and also to succesfully build machine-os-content for k8s rebase w/ 1.25

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Sep 16, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2022
@openshift-ci-robot
Copy link

@kikisdeliveryservice: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

# fedora:29 is an image built within the release scripts:
# https://github.com/openshift/release/blob/b45a09d248b8cdb8fe3bf5f3cfa0b4fee57d04c8/ci-operator/config/openshift/kubernetes/openshift-kubernetes-release-4.10.yaml#L63-L65
FROM fedora:29 AS build
FROM centos:stream9 AS build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be FROM quay.io/centos/centos:stream9 as build. The images on the Docker hub seem not to be updated for CentOS Stream.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll give it a try!

@openshift-ci-robot
Copy link

@kikisdeliveryservice: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@kikisdeliveryservice
Copy link
Author

kikisdeliveryservice commented Sep 16, 2022

arrgh:
Error: Unknown repo: 'built'

need to change to:
enablerepo=rhel-8*

@openshift-ci-robot
Copy link

@kikisdeliveryservice: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@kikisdeliveryservice
Copy link
Author

kikisdeliveryservice commented Sep 16, 2022

Really weird that this is also hitting some of same errors as #1360
Could changing builder from F29 cause these failures? 🤔

@kikisdeliveryservice
Copy link
Author

some changes in ocp/release trying again
/retest-required

@openshift-ci-robot
Copy link

@kikisdeliveryservice: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@kikisdeliveryservice kikisdeliveryservice changed the title [WIP] Dockerfile: use centos:stream9 [WIP] UPSTREAM: <carry>: Dockerfile: use centos:stream9 Sep 19, 2022
@openshift-ci-robot
Copy link

@kikisdeliveryservice: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@kikisdeliveryservice kikisdeliveryservice changed the title [WIP] UPSTREAM: <carry>: Dockerfile: use centos:stream9 UPSTREAM: <carry>: Dockerfile: use centos:stream9 Sep 19, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2022
@kikisdeliveryservice kikisdeliveryservice changed the title UPSTREAM: <carry>: Dockerfile: use centos:stream9 [wip] UPSTREAM: <carry>: Dockerfile: use centos:stream9 Sep 19, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2022
@kikisdeliveryservice kikisdeliveryservice changed the title [wip] UPSTREAM: <carry>: Dockerfile: use centos:stream9 UPSTREAM: <carry>: Dockerfile: use centos:stream9 Sep 19, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2022
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Sep 20, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2022
@soltysh
Copy link
Member

soltysh commented Sep 20, 2022

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 05fd01b and 2 for PR HEAD 7a21246 in total

@soltysh
Copy link
Member

soltysh commented Sep 20, 2022

/test e2e-gcp-upgrade

@soltysh
Copy link
Member

soltysh commented Sep 20, 2022

To prevent the bot from chasing with us I've opened openshift/release#32444 and I'm overriding the failed jobs which failed due to missing base-machine-with-rpms added in that PR
/override ci/prow/e2e-aws-crun
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-gcp-upgrade

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

@soltysh: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ``

Only the following failed contexts/checkruns were expected:

  • ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade
  • ci/prow/4.11-upgrade-from-stable-4.10-images
  • ci/prow/artifacts
  • ci/prow/e2e-agnostic-cmd
  • ci/prow/e2e-aws-cgroupsv2
  • ci/prow/e2e-aws-crun
  • ci/prow/e2e-aws-csi
  • ci/prow/e2e-aws-fips
  • ci/prow/e2e-aws-serial
  • ci/prow/e2e-gcp
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/images
  • ci/prow/integration
  • ci/prow/k8s-e2e-conformance-aws
  • ci/prow/k8s-e2e-gcp
  • ci/prow/k8s-e2e-gcp-serial
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-commits
  • pull-ci-openshift-kubernetes-master-4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade
  • pull-ci-openshift-kubernetes-master-4.11-upgrade-from-stable-4.10-images
  • pull-ci-openshift-kubernetes-master-artifacts
  • pull-ci-openshift-kubernetes-master-e2e-agnostic-cmd
  • pull-ci-openshift-kubernetes-master-e2e-aws-cgroupsv2
  • pull-ci-openshift-kubernetes-master-e2e-aws-crun
  • pull-ci-openshift-kubernetes-master-e2e-aws-csi
  • pull-ci-openshift-kubernetes-master-e2e-aws-fips
  • pull-ci-openshift-kubernetes-master-e2e-aws-serial
  • pull-ci-openshift-kubernetes-master-e2e-gcp
  • pull-ci-openshift-kubernetes-master-e2e-gcp-upgrade
  • pull-ci-openshift-kubernetes-master-images
  • pull-ci-openshift-kubernetes-master-integration
  • pull-ci-openshift-kubernetes-master-k8s-e2e-conformance-aws
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial
  • pull-ci-openshift-kubernetes-master-unit
  • pull-ci-openshift-kubernetes-master-verify
  • pull-ci-openshift-kubernetes-master-verify-commits
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

To prevent the bot from chasing with us I've opened openshift/release#32444 and I'm overriding the failed jobs which failed due to missing base-machine-with-rpms added in that PR
/override ci/prow/e2e-aws-crun
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member

soltysh commented Sep 20, 2022

/override ci/prow/e2e-aws-crun
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-gcp-upgrade

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-crun, ci/prow/e2e-aws-serial, ci/prow/e2e-gcp-upgrade

In response to this:

/override ci/prow/e2e-aws-crun
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member

soltysh commented Sep 20, 2022

/override ci/prow/e2e-aws-csi
/override ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade
/override ci/prow/e2e-agnostic-cmd

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

@soltysh: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ``

Only the following failed contexts/checkruns were expected:

  • ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade
  • ci/prow/4.11-upgrade-from-stable-4.10-images
  • ci/prow/artifacts
  • ci/prow/e2e-agnostic-cmd
  • ci/prow/e2e-aws-cgroupsv2
  • ci/prow/e2e-aws-crun
  • ci/prow/e2e-aws-csi
  • ci/prow/e2e-aws-fips
  • ci/prow/e2e-aws-serial
  • ci/prow/e2e-gcp
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/images
  • ci/prow/integration
  • ci/prow/k8s-e2e-conformance-aws
  • ci/prow/k8s-e2e-gcp
  • ci/prow/k8s-e2e-gcp-serial
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-commits
  • pull-ci-openshift-kubernetes-master-4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade
  • pull-ci-openshift-kubernetes-master-4.11-upgrade-from-stable-4.10-images
  • pull-ci-openshift-kubernetes-master-artifacts
  • pull-ci-openshift-kubernetes-master-e2e-agnostic-cmd
  • pull-ci-openshift-kubernetes-master-e2e-aws-cgroupsv2
  • pull-ci-openshift-kubernetes-master-e2e-aws-crun
  • pull-ci-openshift-kubernetes-master-e2e-aws-csi
  • pull-ci-openshift-kubernetes-master-e2e-aws-fips
  • pull-ci-openshift-kubernetes-master-e2e-aws-serial
  • pull-ci-openshift-kubernetes-master-e2e-gcp
  • pull-ci-openshift-kubernetes-master-e2e-gcp-upgrade
  • pull-ci-openshift-kubernetes-master-images
  • pull-ci-openshift-kubernetes-master-integration
  • pull-ci-openshift-kubernetes-master-k8s-e2e-conformance-aws
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial
  • pull-ci-openshift-kubernetes-master-unit
  • pull-ci-openshift-kubernetes-master-verify
  • pull-ci-openshift-kubernetes-master-verify-commits
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ci/prow/e2e-aws-csi
/override ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade
/override ci/prow/e2e-agnostic-cmd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

@kikisdeliveryservice: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-cmd 7a21246 link false /test e2e-agnostic-cmd
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade 7a21246 link false /test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-csi 7a21246 link false /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8c7c967 into openshift:master Sep 20, 2022
@kikisdeliveryservice kikisdeliveryservice deleted the try-centos branch September 20, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants