Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch sdn-4.9-kubernetes-1.22.0-rc.0: Do not force DNS service endpoints to be local #1386

Merged
merged 1 commit into from Oct 7, 2022
Merged

Branch sdn-4.9-kubernetes-1.22.0-rc.0: Do not force DNS service endpoints to be local #1386

merged 1 commit into from Oct 7, 2022

Conversation

martinkennelly
Copy link

Currently, we direct DNS traffic to local even if the endpoint is not ready. This is not prefer local
functionality.

Signed-off-by: Martin Kennelly mkennell@redhat.com

@martinkennelly
Do not force DNS service endpoints to be local
e5c200c 
Currently, we direct DNS traffic to local even if the
endpoint is not ready. This is not prefer local
functionality.

Signed-off-by: Martin Kennelly <mkennell@redhat.com>
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 7, 2022
@openshift-ci-robot
Copy link

@martinkennelly: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from abhat and tssurya October 7, 2022 16:33
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: martinkennelly
Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval by writing /assign @danwinship in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@martinkennelly martinkennelly changed the title Do not force DNS service endpoints to be local Branch sdn-4.9-kubernetes-1.22.0-rc.0: Do not force DNS service endpoints to be local Oct 7, 2022
@martinkennelly
Copy link
Author

This is needed for SDN 4.9

@martinkennelly
Copy link
Author

/cc @danwinship

@openshift-ci openshift-ci bot requested a review from danwinship October 7, 2022 16:37
@danwinship danwinship merged commit 0032072 into openshift:sdn-4.9-kubernetes-1.22.0-rc.0 Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhat abhat Awaiting requested review from abhat

@tssurya tssurya Awaiting requested review from tssurya

@danwinship danwinship Awaiting requested review from danwinship

Assignees
No one assigned
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martinkennelly @openshift-ci-robot @danwinship