OCPBUGS-2774: UPSTREAM: 112807 Fix Load balancer services with xTP local

[JoelSpeed]

This is a blocker bug that was introduced by the K8s 1.25 rebase. The bug is present in all Kube versions upstream 1.25.0 <= x < 1.25.3. Since we are currently based on 1.25.2 this has not been included yet.

The result of this bug is that, for any LoadBalancer service (such as that used by the default router), that has an externalTrafficPolicy: local, the load balancer node membership is never updated after the service is created. As MachineSets scale up and down, this would result in a loss of ingress.

Links to the upstream issue in the bug.

[openshift-ci-robot]

@JoelSpeed: This pull request references Jira Issue OCPBUGS-2774, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.0) matches configured target version for branch (4.12.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a blocker bug that was introduced by the K8s 1.25 rebase. The bug is present in all Kube versions upstream 1.25.0 <= x < 1.25.3. Since we are currently based on 1.25.2 this has not been included yet.

The result of this bug is that, for any LoadBalancer service (such as that used by the default router), that has an externalTrafficPolicy: local, the load balancer node membership is never updated after the service is created. As MachineSets scale up and down, this would result in a loss of ingress.

Links to the upstream issue in the bug.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@JoelSpeed: the contents of this pull request could be automatically validated.

The following commits are valid:

• be31e8d|UPSTREAM: 112807: Revert 109706 + 111691: Fix Load balancer services with xTP local: the upstream PR kubernetes/kubernetes#112807 has merged

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[soltysh]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

I've manually verified this by building a cluster from this PR and scaling up and down machinesets a few times, I can see the new machines and old machines being added and removed as expected

[JoelSpeed]

/retest-required

[JoelSpeed]

/skip
/retest-required

[JoelSpeed]

/retest-required

[openshift-ci]

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-ovn-cmd	be31e8d	link	false	/test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-csi	be31e8d	link	false	/test e2e-aws-csi
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade	be31e8d	link	false	/test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@JoelSpeed: All pull requests linked via external trackers have merged:

• openshift/kubernetes#1400

Jira Issue OCPBUGS-2774 has been moved to the MODIFIED state.

In response to this:

This is a blocker bug that was introduced by the K8s 1.25 rebase. The bug is present in all Kube versions upstream 1.25.0 <= x < 1.25.3. Since we are currently based on 1.25.2 this has not been included yet.

The result of this bug is that, for any LoadBalancer service (such as that used by the default router), that has an externalTrafficPolicy: local, the load balancer node membership is never updated after the service is created. As MachineSets scale up and down, this would result in a loss of ingress.

Links to the upstream issue in the bug.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.