Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-3502: UPSTREAM: <drop>: Bump library-go. #1406

Merged

Conversation

benluddy
Copy link

@benluddy benluddy commented Nov 2, 2022

This pulls in openshift/library-go#1407 to share one route/v1 validation and defaulting implementation between openshift-apiserver (typical clusters) and kube-apiserver (clusters serving routes via CRD, i.e. MicroShift).

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Nov 2, 2022
@openshift-ci-robot
Copy link

@benluddy: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Nov 2, 2022
@benluddy
Copy link
Author

benluddy commented Nov 2, 2022

/test e2e-aws-ovn-fips

@openshift-ci
Copy link

openshift-ci bot commented Nov 2, 2022

@benluddy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade fad59a8 link false /test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik
Copy link

mfojtik commented Nov 7, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@mfojtik mfojtik removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Nov 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit 71746b7 into openshift:master Nov 8, 2022
@benluddy
Copy link
Author

benluddy commented Nov 9, 2022

/cherry-pick release-4.12

@openshift-cherrypick-robot

@benluddy: new pull request created: #1414

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benluddy benluddy changed the title UPSTREAM: <drop>: Bump library-go. OCPBUGS-3502: UPSTREAM: <drop>: Bump library-go. Nov 10, 2022
@openshift-ci-robot
Copy link

@benluddy: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3502 has been moved to the MODIFIED state.

In response to this:

This pulls in openshift/library-go#1407 to share one route/v1 validation and defaulting implementation between openshift-apiserver (typical clusters) and kube-apiserver (clusters serving routes via CRD, i.e. MicroShift).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants