UPSTREAM: <carry>: Ensure balanced brackets in annotated test names

[stbenjam]

We recently started marking tests with apigroups, and in one case we missed the closing bracket on the annotation resulting in the test being erroneously skipped. See openshift/origin#27525

This adds a check in the annotation generation, and errors when brackets are unbalanced.

Example:
$ ./hack/verify-generated.sh
FAILURE after 12.870s: hack/verify-generated.sh:13: executing '/home/stbenjam/go/src/github.com/openshift/origin/hack/update-generated.sh' expecting success: the command returned the wrong error code
Standard output from the command:
Nov  4 14:11:25.026: INFO: Enabling in-tree volume drivers
Nov  4 14:11:25.026: INFO: Warning: deprecated ENABLE_STORAGE_GCE_PD_DRIVER used. This will be removed in a future release. Use --enabled-volume-drivers=gcepd instead
Nov  4 14:11:25.026: INFO: Enabled gcepd and windows-gcepd in-tree volume drivers

Standard error from the command:
failed: unbalanced brackets in test name:
[Top Level] [sig-scheduling][Early] The openshift-console console pods [apigroup:console.openshift.io should be scheduled on different nodes
                                                                       ^

[openshift-ci-robot]

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 92d174b|UPSTREAM: : Ensure balanced brackets in annotated test names: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• ffa7425|UPSTREAM: : Ensure balanced brackets in annotated test names: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 966e477|Simplify edge cases in bracket matching: does not specify an upstream backport in the commit message
• ffa7425|UPSTREAM: : Ensure balanced brackets in annotated test names: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 61955d0|UPSTREAM: revert: : Bug 2098054 tag AWS security group at creation: does not specify an upstream backport in the commit message
• aac4364|UPSTREAM: : Ensure balanced brackets in annotated test names: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 2256387|UPSTREAM: : Ensure balanced brackets in annotated test names: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[soltysh]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[soltysh]

/remove-label backports/unvalidated-commits
/label backports/validated-commits

[soltysh]

/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-csi

the failures are not related with this changes, which is only adding extra checks for brackets inside the test names

[openshift-ci]

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade, ci/prow/e2e-aws-csi, ci/prow/e2e-gcp-ovn-upgrade

In response to this:

/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-csi

the failures are not related with this changes, which is only adding extra checks for brackets inside the test names

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD aad4cdf and 2 for PR HEAD 2256387 in total

[soltysh]

/override ci/prow/e2e-gcp

[openshift-ci]

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-gcp

In response to this:

/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.