DO NOT MERGE: prototype openshift-tests wrapper/separation #1433
Conversation
bparees
changed the title
bparees
changed the title
bparees
added
the
do-not-merge/hold
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@bparees: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
1 similar comment
|
@bparees: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bparees The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bparees: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
| github.com/onsi/ginkgo => github.com/onsi/ginkgo v1.11.0 | ||
| github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.0.0-20221104153651-0e2187c0d222 | ||
| github.com/openshift/library-go => github.com/openshift/library-go v0.0.0-20221101142545-76526edf66e8 | ||
| github.com/openshift/origin => github.com/bparees/origin v0.0.0-20221207195106-867dedaea002 |
There was a problem hiding this comment.
meaning the origin dep in general? yeah, ultimately we probably need to factor some code out into a new repo and then have origin + o/k both dep that code.
luckily it is not that much code at this point so i don't think it'll be too terrible to do.
| @@ -35,11 +35,21 @@ require ( | |||
| ) | |||
|
|
|||
| replace ( | |||
| github.com/containerd/containerd => github.com/containerd/containerd v1.4.9 | |||
There was a problem hiding this comment.
this stands out as a likely diamond. What's it for?
| github.com/imdario/mergo => github.com/imdario/mergo v0.3.6 | ||
| github.com/matttproud/golang_protobuf_extensions => github.com/matttproud/golang_protobuf_extensions v1.0.1 | ||
| github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.0.0-20221005160638-5fa9cd70cd8c | ||
| github.com/mohae/deepcopy => github.com/mohae/deepcopy v0.0.0-20170603005431-491d3605edfb | ||
| github.com/onsi/ginkgo => github.com/onsi/ginkgo v1.11.0 |
|
some of the deps look off, but I like the idea here. The wrapper doesn't look awful. I wonder if we actually need to instantiate all the providers since we're going to execve eventually anyway, right? |
openshift-merge-robot
added
the
needs-rebase
|
@bparees: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bparees: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
goes along with openshift/origin#27563