Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-14589: [release-4.13] UPSTREAM: 118383: bump cadvisor for upstream patch 3301 #1596

Merged
merged 1 commit into from Jun 7, 2023

Conversation

harche
Copy link

@harche harche commented Jun 5, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-14589

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Signed-off-by: Harshal Patil <harpatil@redhat.com>
@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 5, 2023
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 5, 2023
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 5, 2023
@openshift-ci-robot
Copy link

@harche: This pull request references Jira Issue OCPBUGS-14589, which is invalid:

  • expected the bug to target the "4.13.z" version, but it targets "4.13.0" instead
  • expected Jira Issue OCPBUGS-14589 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-14589

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@harche harche changed the title OCPBUGS-14589: [release 4.13] UPSTREAM: 118383: bump cadvisor for upstream patch 3301 OCPBUGS-14589: [release-4.13] UPSTREAM: 118383: bump cadvisor for upstream patch 3301 Jun 5, 2023
@harche
Copy link
Author

harche commented Jun 5, 2023

/jira refresh

@openshift-ci-robot
Copy link

@harche: This pull request references Jira Issue OCPBUGS-14589, which is invalid:

  • expected Jira Issue OCPBUGS-14589 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from deads2k and soltysh June 5, 2023 17:55
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jun 5, 2023
@harche
Copy link
Author

harche commented Jun 5, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 5, 2023
@openshift-ci-robot
Copy link

@harche: This pull request references Jira Issue OCPBUGS-14589, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-4053 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-4053 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @lyman9966

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from lyman9966 June 5, 2023 17:56
@rphillips
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, rphillips, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@soltysh
Copy link
Member

soltysh commented Jun 6, 2023

/remove-label backports/unvalidated-commits
/label backports/validated-commits
/label backport-risk-assessed

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Jun 6, 2023
@soltysh
Copy link
Member

soltysh commented Jun 6, 2023

/retest

@harche
Copy link
Author

harche commented Jun 6, 2023

/retest

@harche
Copy link
Author

harche commented Jun 6, 2023

@sunilcio can you apply cherry-pick-approved label on this PR? Thanks.

@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2023

@harche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lyman9966
Copy link

/cherry-pick-approved

@harche
Copy link
Author

harche commented Jun 7, 2023

/check-required-labels

@harche
Copy link
Author

harche commented Jun 7, 2023

@lyman9966 Thanks for applying the required label. But I think there is typo while applying the label. IIRC, it should be,

/label cherry-pick-approved

@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2023

@harche: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

@lyman9966 Thanks for applying the required label. But I think there is typo while applying the label. IIRC, it should be,

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 7d22122 into openshift:release-4.13 Jun 7, 2023
18 checks passed
@openshift-ci-robot
Copy link

@harche: Jira Issue OCPBUGS-14589: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14589 has been moved to the MODIFIED state.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-14589

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lyman9966
Copy link

/label cherry-pick-approved

@openshift-merge-robot
Copy link

Fix included in accepted release 4.13.0-0.nightly-2023-06-08-094044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet