Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: kubelet: add a way to toggle the devicemanager check #1598

Closed
wants to merge 1 commit into from

Conversation

ffromani
Copy link

@ffromani ffromani commented Jun 7, 2023

WIP TBD

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 7, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2023
@openshift-ci-robot
Copy link

@ffromani: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mrunalp and rphillips June 7, 2023 12:58
@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ffromani
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Francesco Romani <fromani@redhat.com>
@openshift-ci-robot
Copy link

@ffromani: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@swatisehgal
Copy link

/cc

@openshift-ci openshift-ci bot requested a review from swatisehgal June 7, 2023 13:13
@ffromani
Copy link
Author

ffromani commented Jun 7, 2023

/cc @fabiand @stu-gott @xpivarc @MarSik @yanirq

this is still very much WIP but the basic concept is in place.
Should the default be old-behavior ("relaxed") or new-behavior ("strict")?

@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2023

@ffromani: GitHub didn't allow me to request PR reviews from the following users: xpivarc.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @fabiand @stu-gott @xpivarc @MarSik @yanirq

this is still very much WIP but the basic concept is in place.
Should the default be old-behavior ("relaxed") or new-behavior ("strict")?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani ffromani marked this pull request as draft June 7, 2023 16:38
@ffromani
Copy link
Author

ffromani commented Jun 7, 2023

converting to draft to save CPU cycles

@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2023

@ffromani: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-commits aa7d7f4 link true /test verify-commits
ci/prow/e2e-agnostic-ovn-cmd aa7d7f4 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-gcp aa7d7f4 link true /test e2e-gcp
ci/prow/e2e-gcp-ovn-upgrade aa7d7f4 link true /test e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ffromani
Copy link
Author

obsoleted by #1618

@ffromani
Copy link
Author

no longer needed, we validated/we are validating the PR in a different way

@ffromani ffromani closed this Jul 18, 2023
@ffromani ffromani deleted the devmgr-relaxed-option branch July 18, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants