OCPBUGS-18325: UPSTREAM: <carry>: Prefer local TCP endpoint for cluster DNS service

[martinkennelly]

/cc

Almost clean cherry-pick - needed to modify parameters passed to func assertIPTablesRulesEqual.
In 4.13 version of this it looked like:

 assertIPTablesRulesEqual(t, getLine(), true, expected, fp.iptablesData.String())

[openshift-ci-robot]

@martinkennelly: This pull request references Jira Issue OCPBUGS-18325, which is invalid:

• expected Jira Issue OCPBUGS-18325 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/cc

Almost clean cherry-pick - needed to modify parameters passed to func assertIPTablesRulesEqual.
In 4.13 version of this it looked like:

assertIPTablesRulesEqual(t, getLine(), true, expected, fp.iptablesData.String())

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@martinkennelly: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• db2259d|UPSTREAM: : Prefer local TCP endpoint for cluster DNS service: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci]

@martinkennelly: GitHub didn't allow me to request PR reviews from the following users: martinkennelly.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc

Almost clean cherry-pick - needed to modify parameters passed to func assertIPTablesRulesEqual.
In 4.13 version of this it looked like:

assertIPTablesRulesEqual(t, getLine(), true, expected, fp.iptablesData.String())

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[martinkennelly]

/jira refresh

[openshift-ci-robot]

@martinkennelly: This pull request references Jira Issue OCPBUGS-18325, which is valid. The bug has been moved to the POST state.

4 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-12994 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (mfiedler@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: martinkennelly
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[martinkennelly]

I checked SDN go mod for 4.12 and its pointing to this branch. Weirdly, theres a greater z version here (sdn-4.12-kubernetes-1.25.4) than the branch this PR targets but I confirmed via commit hashes in SDN go mod replaces.

[openshift-ci-robot]

@martinkennelly: Jira Issue OCPBUGS-18325: All pull requests linked via external trackers have merged:

• openshift/kubernetes#1682

Jira Issue OCPBUGS-18325 has been moved to the MODIFIED state.

In response to this:

/cc

Almost clean cherry-pick - needed to modify parameters passed to func assertIPTablesRulesEqual.
In 4.13 version of this it looked like:

assertIPTablesRulesEqual(t, getLine(), true, expected, fp.iptablesData.String())

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.12.0-0.nightly-2023-09-05-004152