Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-18249: <carry>: Export cpu stats of ovs.slice via prometheus #1699

Merged
merged 1 commit into from Oct 9, 2023
Merged

[release-4.14] OCPBUGS-18249: <carry>: Export cpu stats of ovs.slice via prometheus #1699

merged 1 commit into from Oct 9, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1686

/assign rphillips

When a PerformanceProfile is being used, OVS from affected nodes runs in a /ovs.slice cgroup. The proper way to query for the OVS cpu consumption becomes: container_cpu_usage_seconds_total{id=~"/ovs.slice/.+"}

@MarSik
UPSTREAM: <carry>: Export cpu stats of ovs.slice via prometheus
55ef58d 
When a PerformanceProfile configures a node for cpu partitioning,
it also lets OVS use all the cpus available to burstable pods.
To be able to do that, OVS was moved to its own slice and that
slice needs to be re-added to cAdvisor for monitoring purposes.
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Sep 12, 2023
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 12, 2023
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@rphillips
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2023
@MarSik
Copy link

MarSik commented Sep 14, 2023

/retest-required

@MarSik
Copy link

MarSik commented Sep 18, 2023

@mrunalp Could you help with the necessary labels please?

@mrunalp mrunalp added approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Sep 26, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gangwgr
Copy link

gangwgr commented Sep 27, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 27, 2023
@MarSik
Copy link

MarSik commented Oct 3, 2023

/retitle
[release-4.14] OCPBUGS-18249: : Export cpu stats of ovs.slice via prometheus

@openshift-ci openshift-ci bot changed the title [release-4.14] <carry>: Export cpu stats of ovs.slice via prometheus [release-4.14] OCPBUGS-18249: <carry>: Export cpu stats of ovs.slice via prometheus Oct 3, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 3, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-18249, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set
  • expected Jira Issue OCPBUGS-18249 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1686

/assign rphillips

When a PerformanceProfile is being used, OVS from affected nodes runs in a /ovs.slice cgroup. The proper way to query for the OVS cpu consumption becomes: container_cpu_usage_seconds_total{id=~"/ovs.slice/.+"}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MarSik
Copy link

MarSik commented Oct 3, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 3, 2023
@openshift-ci-robot
Copy link

@MarSik: This pull request references Jira Issue OCPBUGS-18249, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20043 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-20043 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @gsr-shanks

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gsr-shanks October 3, 2023 14:28
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9ef6de6 and 2 for PR HEAD 55ef58d in total

@MarSik
Copy link

MarSik commented Oct 4, 2023

/retest-required

1 similar comment
@MarSik
Copy link

MarSik commented Oct 5, 2023

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fd4d1f9 and 1 for PR HEAD 55ef58d in total

@MarSik
Copy link

MarSik commented Oct 6, 2023

/retest-required

@rphillips
Copy link

/test unit

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4e94a88 and 0 for PR HEAD 55ef58d in total

@openshift-ci-robot
Copy link

/hold

Revision 55ef58d was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-18249, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20043 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-20043 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @gsr-shanks

In response to this:

This is an automated cherry-pick of #1686

/assign rphillips

When a PerformanceProfile is being used, OVS from affected nodes runs in a /ovs.slice cgroup. The proper way to query for the OVS cpu consumption becomes: container_cpu_usage_seconds_total{id=~"/ovs.slice/.+"}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MarSik
Copy link

MarSik commented Oct 9, 2023

/retest
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4e94a88 and 2 for PR HEAD 55ef58d in total

@MarSik
Copy link

MarSik commented Oct 9, 2023

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 98158f9 into openshift:release-4.14 Oct 9, 2023
19 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-18249: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18249 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1686

/assign rphillips

When a PerformanceProfile is being used, OVS from affected nodes runs in a /ovs.slice cgroup. The proper way to query for the OVS cpu consumption becomes: container_cpu_usage_seconds_total{id=~"/ovs.slice/.+"}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.14.0-0.nightly-2023-10-10-084534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

@gsr-shanks gsr-shanks Awaiting requested review from gsr-shanks

Assignees

@rphillips rphillips

@kasturinarra kasturinarra

@zhouying7780 zhouying7780

@xingxingxia xingxingxia

@sunilcio sunilcio

@duanwei33 duanwei33

@wangke19 wangke19

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet