Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-19452: UPSTREAM: 119317: change rolling update logic to exclude sunsetting nodes #1716

Merged
merged 1 commit into from Sep 25, 2023
Merged

OCPBUGS-19452: UPSTREAM: 119317: change rolling update logic to exclude sunsetting nodes #1716

merged 1 commit into from Sep 25, 2023

Conversation

atiratree
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Sep 20, 2023
@openshift-ci-robot
Copy link

@atiratree: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@atiratree atiratree changed the title UPSTREAM: 119317: change rolling update logic to exclude sunsetting nodes OCPBUGS-19452: UPSTREAM: 119317: change rolling update logic to exclude sunsetting nodes Sep 20, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 20, 2023
@openshift-ci-robot
Copy link

@atiratree: This pull request references Jira Issue OCPBUGS-19452, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh
soltysh approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fde2a12 and 2 for PR HEAD 8e6b965 in total

@atiratree
Copy link
Member Author

/retest-required

9 similar comments
@atiratree
Copy link
Member Author

/retest-required

@atiratree
Copy link
Member Author

/retest-required

@atiratree
Copy link
Member Author

/retest-required

@atiratree
Copy link
Member Author

/retest-required

@atiratree
Copy link
Member Author

/retest-required

@atiratree
Copy link
Member Author

/retest-required

@atiratree
Copy link
Member Author

/retest-required

@atiratree
Copy link
Member Author

/retest-required

@atiratree
Copy link
Member Author

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023 •
edited

@atiratree: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/k8s-e2e-aws-ovn-serial 8e6b965 link false /test k8s-e2e-aws-ovn-serial
ci/prow/e2e-aws-csi 8e6b965 link false /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@atiratree
Copy link
Member Author

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 7545fd9 into openshift:master Sep 25, 2023
17 of 19 checks passed
@openshift-ci-robot
Copy link

@atiratree: Jira Issue OCPBUGS-19452: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19452 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah Miciah mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@zhouying7780 zhouying7780 Awaiting requested review from zhouying7780

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atiratree @openshift-ci-robot @soltysh @openshift-merge-robot @mochizuki875