Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-20115: Do not allow nodes to set forbidden openshift labels #1736

Merged
merged 1 commit into from Oct 7, 2023

Conversation

harche
Copy link

@harche harche commented Oct 4, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-20115

Special notes for your reviewer:

e2e PR - openshift/origin#28297

Does this PR introduce a user-facing change?

Do not allow nodes to set forbidden openshift labels

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@openshift-ci-robot
Copy link

@harche: An error was encountered searching for bug OCPBUGS-19869 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-19869

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Do not allow nodes to set forbidden openshift labels

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 4, 2023
@openshift-ci-robot
Copy link

@harche: An error was encountered searching for bug OCPBUGS-19869 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-19869

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Do not allow nodes to set forbidden openshift labels

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 4, 2023
@openshift-ci-robot
Copy link

@harche: An error was encountered searching for bug OCPBUGS-19869 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-19869

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Do not allow nodes to set forbidden openshift labels

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@harche harche changed the title OCPBUGS-19869: Do not allow nodes to set forbidden openshift labels OCPBUGS-19869: [release-4.14] Do not allow nodes to set forbidden openshift labels Oct 4, 2023
@openshift-ci openshift-ci bot requested review from mfojtik and soltysh October 4, 2023 19:45
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Oct 4, 2023
@openshift-ci-robot
Copy link

@harche: An error was encountered searching for bug OCPBUGS-19869 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-19869

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Do not allow nodes to set forbidden openshift labels

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harche harche changed the title OCPBUGS-19869: [release-4.14] Do not allow nodes to set forbidden openshift labels [release-4.14] OCPBUGS-19869: Do not allow nodes to set forbidden openshift labels Oct 4, 2023
@openshift-ci-robot
Copy link

@harche: An error was encountered searching for bug OCPBUGS-19869 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-19869

Special notes for your reviewer:

e2e PR - openshift/origin#28297

Does this PR introduce a user-facing change?

Do not allow nodes to set forbidden openshift labels

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harche harche force-pushed the update_fix_414 branch 2 times, most recently from 5de42df to 0aab772 Compare October 4, 2023 20:22
@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@rphillips
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@openshift-ci-robot
Copy link

@harche: An error was encountered searching for bug OCPBUGS-19869 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-19869

Special notes for your reviewer:

e2e PR - openshift/origin#28297

Does this PR introduce a user-facing change?

Do not allow nodes to set forbidden openshift labels

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrunalp
Copy link
Member

mrunalp commented Oct 4, 2023

@deads2k ptal.

@deads2k
Copy link

deads2k commented Oct 4, 2023

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2023
@openshift-ci-robot
Copy link

@harche: An error was encountered searching for bug OCPBUGS-19869 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-19869

Special notes for your reviewer:

e2e PR - openshift/origin#28297

Does this PR introduce a user-facing change?

Do not allow nodes to set forbidden openshift labels

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harche
Copy link
Author

harche commented Oct 4, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2023
@openshift-ci-robot
Copy link

@harche: An error was encountered searching for bug OCPBUGS-19869 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-19869

Special notes for your reviewer:

e2e PR - openshift/origin#28297

Does this PR introduce a user-facing change?

Do not allow nodes to set forbidden openshift labels

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@openshift-ci-robot
Copy link

@harche: This pull request references Jira Issue OCPBUGS-20115, which is invalid:

  • expected Jira Issue OCPBUGS-20115 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Retaining the jira/valid-bug label as it was manually added.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-20115

Special notes for your reviewer:

e2e PR - openshift/origin#28297

Does this PR introduce a user-facing change?

Do not allow nodes to set forbidden openshift labels

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

@harche: This pull request references Jira Issue OCPBUGS-20115, which is invalid:

  • expected Jira Issue OCPBUGS-20115 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Retaining the jira/valid-bug label as it was manually added.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-20115

Special notes for your reviewer:

e2e PR - openshift/origin#28297

Does this PR introduce a user-facing change?

Do not allow nodes to set forbidden openshift labels

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9ef6de6 and 2 for PR HEAD 3991b720adc13bfe0ec5b66eefdac96dc197f904 in total

@rphillips
Copy link

/retest-required

@rphillips
Copy link

Registry flake

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fd4d1f9 and 1 for PR HEAD 3991b720adc13bfe0ec5b66eefdac96dc197f904 in total

@harche
Copy link
Author

harche commented Oct 5, 2023

/retest-required

Signed-off-by: Harshal Patil <harpatil@redhat.com>
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 6, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2023
@openshift-ci-robot
Copy link

@harche: This pull request references Jira Issue OCPBUGS-20115, which is invalid:

  • expected Jira Issue OCPBUGS-20115 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Retaining the jira/valid-bug label as it was manually added.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-20115

Special notes for your reviewer:

e2e PR - openshift/origin#28297

Does this PR introduce a user-facing change?

Do not allow nodes to set forbidden openshift labels

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@harche
Copy link
Author

harche commented Oct 6, 2023

/test unit
/test e2e-agnostic-ovn-cmd

@harche
Copy link
Author

harche commented Oct 6, 2023

/test e2e-aws-ovn-serial

@deads2k deads2k removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 6, 2023
@openshift-ci-robot
Copy link

@harche: This pull request references Jira Issue OCPBUGS-20115, which is invalid:

  • expected Jira Issue OCPBUGS-20115 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Retaining the jira/valid-bug label as it was manually added.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-20115

Special notes for your reviewer:

e2e PR - openshift/origin#28297

Does this PR introduce a user-facing change?

Do not allow nodes to set forbidden openshift labels

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link

deads2k commented Oct 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, harche, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harche
Copy link
Author

harche commented Oct 6, 2023

/test unit

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fd4d1f9 and 2 for PR HEAD ff221b9 in total

@harche
Copy link
Author

harche commented Oct 6, 2023

/test e2e-aws-ovn-crun

@harche
Copy link
Author

harche commented Oct 6, 2023

/test unit

1 similar comment
@harche
Copy link
Author

harche commented Oct 7, 2023

/test unit

@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2023

@harche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 4e94a88 into openshift:release-4.14 Oct 7, 2023
19 checks passed
@openshift-ci-robot
Copy link

@harche: Jira Issue OCPBUGS-20115: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20115 has been moved to the MODIFIED state.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/OCPBUGS-20115

Special notes for your reviewer:

e2e PR - openshift/origin#28297

Does this PR introduce a user-facing change?

Do not allow nodes to set forbidden openshift labels

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.14.0-0.nightly-2023-10-06-234925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet