Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-16922: Remove skip flag for e2e tests related to AdmissionWebhookMatchConditions #1738

Closed
wants to merge 2 commits into from
Closed

OCPBUGS-16922: Remove skip flag for e2e tests related to AdmissionWebhookMatchConditions #1738

wants to merge 2 commits into from

Conversation

dinhxuanvu
Copy link
Member

The AdmissionWebhookMatchConditions feature is enabled by default on k8s 1.28. It is currently in TechPreviewNoUpgrade feature set in openshift api.

Signed-off-by: Vu Dinh vudinh@outlook.com

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 4, 2023
@openshift-ci-robot
Copy link

@dinhxuanvu: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh October 4, 2023 22:52
@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dinhxuanvu
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@dinhxuanvu: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@dinhxuanvu dinhxuanvu changed the title Remove skip flag for e2e tests related to AdmissionWebhookMatchConditions OCPBUGS-16922: Remove skip flag for e2e tests related to AdmissionWebhookMatchConditions Oct 5, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 5, 2023
@openshift-ci-robot
Copy link

@dinhxuanvu: This pull request references Jira Issue OCPBUGS-16922, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.15" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The AdmissionWebhookMatchConditions feature is enabled by default on k8s 1.28. It is currently in TechPreviewNoUpgrade feature set in openshift api.

Signed-off-by: Vu Dinh vudinh@outlook.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dinhxuanvu
UPSTREAM: <revert>: Disable e2e tests related to AdmissionWebhookMatc…
fdfef36 
…hConditions

The AdmissionWebhookMatchConditions feature is enabled by default on k8s 1.28.
It is currently in TechPreviewNoUpgrade feature set in openshift api.

Signed-off-by: Vu Dinh <vudinh@outlook.com>
@openshift-ci-robot
Copy link

@dinhxuanvu: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@dinhxuanvu
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 5, 2023
@openshift-ci-robot
Copy link

@dinhxuanvu: This pull request references Jira Issue OCPBUGS-16922, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from wangke19 October 5, 2023 14:07
bertinatto
bertinatto reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinhxuanvu before re-enabling these tests, I believe you need to stop force-disabling the feature in OpenShift first [1].

[1] https://github.com/openshift/api/blob/master/config/v1/types_feature.go#L173

@dinhxuanvu
Copy link
Member Author

@dinhxuanvu before re-enabling these tests, I believe you need to stop force-disabling the feature in OpenShift first [1].

[1] https://github.com/openshift/api/blob/master/config/v1/types_feature.go#L173

I opened this PR to do that: openshift/api#1611

@dinhxuanvu
Copy link
Member Author

/retest-required

1 similar comment
@dinhxuanvu
Copy link
Member Author

/retest-required

@dinhxuanvu
UPSTREAM: <drop>: bump openshift/api
8bd154f 
Signed-off-by: Vu Dinh <vudinh@outlook.com>
@openshift-ci-robot
Copy link

@dinhxuanvu: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Oct 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

@dinhxuanvu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-crun-wasm 8bd154f link true /test e2e-aws-crun-wasm
ci/prow/e2e-aws-ovn-cgroupsv2 8bd154f link true /test e2e-aws-ovn-cgroupsv2
ci/prow/k8s-e2e-gcp-ovn 8bd154f link true /test k8s-e2e-gcp-ovn
ci/prow/artifacts 8bd154f link true /test artifacts
ci/prow/unit 8bd154f link true /test unit
ci/prow/e2e-aws-ovn-serial 8bd154f link true /test e2e-aws-ovn-serial
ci/prow/k8s-e2e-conformance-aws 8bd154f link true /test k8s-e2e-conformance-aws
ci/prow/e2e-aws-ovn-fips 8bd154f link true /test e2e-aws-ovn-fips
ci/prow/verify 8bd154f link true /test verify
ci/prow/e2e-agnostic-ovn-cmd 8bd154f link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-gcp-ovn-upgrade 8bd154f link true /test e2e-gcp-ovn-upgrade
ci/prow/images 8bd154f link true /test images
ci/prow/k8s-e2e-gcp-serial 8bd154f link true /test k8s-e2e-gcp-serial
ci/prow/verify-commits 8bd154f link true /test verify-commits
ci/prow/e2e-aws-ovn-crun 8bd154f link true /test e2e-aws-ovn-crun
ci/prow/k8s-e2e-aws-ovn-serial 8bd154f link false /test k8s-e2e-aws-ovn-serial
ci/prow/e2e-aws-csi 8bd154f link false /test e2e-aws-csi
ci/prow/integration 8bd154f link true /test integration
ci/prow/e2e-gcp 8bd154f link true /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented Oct 31, 2023 •
edited

Close in favor of #1790
/close

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh closed this Nov 2, 2023
@openshift-ci-robot
Copy link

@dinhxuanvu: This pull request references Jira Issue OCPBUGS-16922. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

The AdmissionWebhookMatchConditions feature is enabled by default on k8s 1.28. It is currently in TechPreviewNoUpgrade feature set in openshift api.

Signed-off-by: Vu Dinh vudinh@outlook.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees
No one assigned
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dinhxuanvu @openshift-ci-robot @openshift-merge-robot @bertinatto @soltysh