Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openshift-hack: Fix sporadic 141 errors in build-rpms #1769

Merged
merged 1 commit into from Oct 19, 2023
Merged

openshift-hack: Fix sporadic 141 errors in build-rpms #1769

merged 1 commit into from Oct 19, 2023

Conversation

aravindhp
Copy link

@aravindhp aravindhp commented Oct 13, 2023 •
edited

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

head sometimes exits before rpmspec finishes piping it all its data. Workaround that by separating the rpmspec and head calls.

Which issue(s) this PR fixes:

Fixes #

Additional documentation

Ref: https://unix.stackexchange.com/questions/580117/debugging-sporadic-141-shell-script-errors

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 13, 2023
@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the kind/flake Categorizes issue or PR as related to a flaky test. label Oct 13, 2023
@openshift-ci-robot
Copy link

@aravindhp: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@aravindhp
Copy link
Author

/test e2e-gcp

ncdc
ncdc reviewed Oct 16, 2023
View reviewed changes
openshift-hack/build-rpms.sh Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link

@aravindhp: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@aravindhp
Copy link
Author

/test e2e-gcp

@ncdc
Copy link

ncdc commented Oct 16, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@ncdc
Copy link

ncdc commented Oct 16, 2023

/lgtm cancel

Commit message needs to be UPSTREAM: <carry>: ...

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@aravindhp
UPSTREAM: <carry>: Fix sporadic 141 errors in build-rpms
a67971f 
"head" sometimes exits before "rpmspec" finishes piping it all its data.
Workaround that by separating the rpmspec and head calls.
@openshift-ci-robot
Copy link

@aravindhp: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@aravindhp
Copy link
Author

/lgtm cancel

Commit message needs to be UPSTREAM: <carry>: ...

@ncdc ah yes, I forgot about that. Fixed.

@ncdc
Copy link

ncdc commented Oct 16, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@tkashem
Copy link

tkashem commented Oct 17, 2023

/lgtm
/approve
/remove-label backports/unvalidated-commits
/label backports/validated-commits

/hold
(feel free to remove the hold if it does not conflict with the rebase activities)
/cc @soltysh

@openshift-ci openshift-ci bot requested a review from soltysh October 17, 2023 12:44
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Oct 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, ncdc, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@aravindhp
Copy link
Author

/retest-required

1 similar comment
@aravindhp
Copy link
Author

/retest-required

@soltysh
Copy link
Member

soltysh commented Oct 18, 2023

/hold cancel
/test unit

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
@aravindhp
Copy link
Author

/cherry-pick release-4.14
/cherry-pick release-4.13
/cherry-pick release-4.12
/cherry-pick release-4.11

@openshift-cherrypick-robot
Copy link

@aravindhp: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14
/cherry-pick release-4.13
/cherry-pick release-4.12
/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp
Copy link
Author

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link

@aravindhp: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp
Copy link
Author

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link

@aravindhp: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp
Copy link
Author

/cherry-pick release-4.11

@openshift-cherrypick-robot
Copy link

@aravindhp: once the present PR merges, I will cherry-pick it on top of release-4.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c044976 and 2 for PR HEAD a67971f in total

@aravindhp
Copy link
Author

/retest-required

@aravindhp
Copy link
Author

/retest-required

🤞🏽

@aravindhp
Copy link
Author

/retest-required

1 similar comment
@aravindhp
Copy link
Author

/retest-required

@soltysh
Copy link
Member

soltysh commented Oct 19, 2023

/override ci/prow/unit
this problem is being tracked elsewhere

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/unit

In response to this:

/override ci/prow/unit
this problem is being tracked elsewhere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

@aravindhp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit d981348 into openshift:master Oct 19, 2023
20 checks passed
@openshift-cherrypick-robot
Copy link

@aravindhp: new pull request created: #1772

In response to this:

/cherry-pick release-4.14
/cherry-pick release-4.13
/cherry-pick release-4.12
/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Oct 19, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@aravindhp: new pull request created: #1773

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@aravindhp: new pull request created: #1774

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 19, 2023
Merged
@openshift-cherrypick-robot
Copy link

@aravindhp: new pull request created: #1775

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 19, 2023
Merged
@aravindhp aravindhp deleted the build-rpms-fix-141 branch October 19, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc left review comments

@soltysh soltysh Awaiting requested review from soltysh

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@ncdc ncdc

@tkashem tkashem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aravindhp @openshift-ci-robot @ncdc @tkashem @soltysh @openshift-cherrypick-robot