Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRKLDS-707: Disable PDBUnhealthyPodEvictionPolicy feature by default even if beta #1777

Conversation

ingvagabund
Copy link
Member

Still needs to be protected by a TP feature gate

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 20, 2023

@ingvagabund: This pull request references WRKLDS-707 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Still needs to be protected by a TP feature gate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 20, 2023
@openshift-ci-robot
Copy link

@ingvagabund: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ingvagabund ingvagabund force-pushed the disable-PDBUnhealthyPodEvictionPolicy-in-beta branch from 195f686 to e45b0ba Compare October 20, 2023 13:59
@ingvagabund
Copy link
Member Author

/validate-backports

@openshift-ci-robot
Copy link

@ingvagabund: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ingvagabund
Once this PR has been reviewed and has the lgtm label, please assign mfojtik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ingvagabund
Copy link
Member Author

/validate-backports

@openshift-ci-robot
Copy link

@ingvagabund: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ingvagabund
Copy link
Member Author

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-cgroupsv2 e45b0ba link true /test e2e-aws-ovn-cgroupsv2
ci/prow/k8s-e2e-conformance-aws e45b0ba link true /test k8s-e2e-conformance-aws
ci/prow/e2e-aws-ovn-crun e45b0ba link true /test e2e-aws-ovn-crun
ci/prow/e2e-gcp e45b0ba link true /test e2e-gcp
ci/prow/e2e-aws-csi 195f68694c9fb685cd62b4545a09588337b6602a link false /test e2e-aws-csi
ci/prow/e2e-aws-crun-wasm e45b0ba link true /test e2e-aws-crun-wasm
ci/prow/e2e-aws-ovn-serial e45b0ba link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-fips e45b0ba link true /test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
this should not be disabled, still discussing in slack

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@ingvagabund ingvagabund deleted the disable-PDBUnhealthyPodEvictionPolicy-in-beta branch October 27, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants