Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openshift-apiserver-4.14-kubernetes-1.27.7] UPSTREAM: <carry>: Enable UnauthenticatedHTTP2DOSMitigation by default #1784

Conversation

dgrisonnet
Copy link
Member

@dgrisonnet dgrisonnet commented Oct 26, 2023

Enable the UnauthenticatedHTTP2DOSMitigation feature gate by default to mitigate the HTTP/2 CVE across all our components.

This is required to avoid feature gates conflicts when importing both k8s.io/kubernetes and k8s.io/apiserver which is the case for at least openshift-apiserver and oauth-apiserver.

Proof: openshift/openshift-apiserver#397

Enable the UnauthenticatedHTTP2DOSMitigation feature gate by default to
mitigate the HTTP/2 CVE across all our components.

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 26, 2023
@openshift-ci-robot
Copy link

@dgrisonnet: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2023
Copy link

openshift-ci bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgrisonnet, dinhxuanvu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k merged commit d61d2d7 into openshift:openshift-apiserver-4.14-kubernetes-1.27.7 Nov 2, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants