New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNF-8809: admission: add new admission for handling shared cpus request #1799
CNF-8809: admission: add new admission for handling shared cpus request #1799
Conversation
@Tal-or: This pull request references CNF-8809 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Tal-or: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
/retest |
1 similar comment
/retest |
458dce6
to
3c2f4a4
Compare
@Tal-or: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
3c2f4a4
to
58959b0
Compare
@Tal-or: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
58959b0
to
9232d25
Compare
@Tal-or: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@Tal-or: This pull request references CNF-8809 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Tal-or: This pull request references CNF-8809 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test unit |
9232d25
to
86f602b
Compare
@Tal-or: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
openshift-kube-apiserver/admission/autoscaling/mixedcpus/admission.go
Outdated
Show resolved
Hide resolved
openshift-kube-apiserver/admission/autoscaling/mixedcpus/admission.go
Outdated
Show resolved
Hide resolved
openshift-kube-apiserver/admission/autoscaling/mixedcpus/admission_test.go
Outdated
Show resolved
Hide resolved
86f602b
to
770dd65
Compare
@Tal-or: This pull request references CNF-8809 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bcdad13
to
6335c48
Compare
@Tal-or: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
/retest |
/lgtm |
/retest |
/test unit |
/retest |
/test unit |
Adding a new mutation plugin that handles the following: 1. In case of `workload.openshift.io/enable-shared-cpus` request, it adds an annotation to hint runtime about the request. runtime is not aware of extended resources, hence we need the annotation. 2. It validates the pod's QoS class and return an error if it's not a guaranteed QoS class 3. It validates that no more than a single resource is being request. 4. It validates that the pod deployed in a namespace that has mixedcpus workloads allowed annotation. For more information see - openshift/enhancements#1396 Signed-off-by: Talor Itzhak <titzhak@redhat.com>
/test unit |
2 similar comments
/test unit |
/test unit |
6335c48
to
ac7efb4
Compare
@Tal-or: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: rphillips, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Tal-or: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-hyperkube-container-v4.16.0-202312080609.p0.g7aa0a74.assembly.stream for distgit openshift-enterprise-hyperkube. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding a new mutation plugin that handles the following:
workload.openshift.io/enable-shared-cpus
request, itadds an annotation to hint runtime about the request. runtime
is not aware of extended resources, hence we need the annotation.
guaranteed QoS class
workloads allowed annotation.
Which issue(s) this PR fixes:
Fixes # NONE
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: