Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-8809: admission: add new admission for handling shared cpus request #1799

Merged

Conversation

Tal-or
Copy link

@Tal-or Tal-or commented Nov 13, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding a new mutation plugin that handles the following:

  1. In case of workload.openshift.io/enable-shared-cpus request, it
    adds an annotation to hint runtime about the request. runtime
    is not aware of extended resources, hence we need the annotation.
  2. It validates the pod's QoS class and return an error if it's not a
    guaranteed QoS class
  3. It validates that no more than a single resource is being request.
  4. It validates that the pod deployed in a namespace that has mixedcpus
    workloads allowed annotation.

Which issue(s) this PR fixes:

Fixes # NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]:  https://github.com/openshift/enhancements/commit/76ea48a88bca15ef6157aacf90b8544a763e6075

@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Nov 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2023

@Tal-or: This pull request references CNF-8809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add new admission for handling shared cpus

Which issue(s) this PR fixes:

Fixes # NONE

Special notes for your reviewer:

Not reviewable yet

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]:  https://github.com/openshift/enhancements/commit/76ea48a88bca15ef6157aacf90b8544a763e6075

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 13, 2023
@openshift-ci-robot
Copy link

@Tal-or: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@Tal-or
Copy link
Author

Tal-or commented Nov 14, 2023

/retest

1 similar comment
@Tal-or
Copy link
Author

Tal-or commented Nov 16, 2023

/retest

@openshift-ci-robot
Copy link

@Tal-or: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@Tal-or: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@Tal-or: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@Tal-or Tal-or changed the title WIP: CNF-8809: admission: add new admission for handling shared cpus request CNF-8809: admission: add new admission for handling shared cpus request Nov 19, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2023

@Tal-or: This pull request references CNF-8809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding a new mutation plugin that handles the following:

  1. In case of workload.openshift.io/enabled-shared-cpus request, it
    adds an annotation to hint runtime about the request. runtime
    is not aware of extended resources, hence we need the annotation.
  2. It validates the pod's QoS class and return an error if it's not a
    guaranteed QoS class
  3. It validates that no more than a single resource is being request.

Which issue(s) this PR fixes:

Fixes # NONE

Special notes for your reviewer:

  • The Mixed-CPUs feature allows guaranteed workloads to have an access for both isolated and shared cpus.
  • This PR alone doesn't enable the feature functionality, there will be following PRs for that.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]:  https://github.com/openshift/enhancements/commit/76ea48a88bca15ef6157aacf90b8544a763e6075

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2023

@Tal-or: This pull request references CNF-8809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding a new mutation plugin that handles the following:

  1. In case of workload.openshift.io/enabled-shared-cpus request, it
    adds an annotation to hint runtime about the request. runtime
    is not aware of extended resources, hence we need the annotation.
  2. It validates the pod's QoS class and return an error if it's not a
    guaranteed QoS class
  3. It validates that no more than a single resource is being request.

Which issue(s) this PR fixes:

Fixes # NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]:  https://github.com/openshift/enhancements/commit/76ea48a88bca15ef6157aacf90b8544a763e6075

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Tal-or
Copy link
Author

Tal-or commented Nov 19, 2023

/test unit

@openshift-ci-robot
Copy link

@Tal-or: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 6, 2023

@Tal-or: This pull request references CNF-8809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding a new mutation plugin that handles the following:

  1. In case of workload.openshift.io/enable-shared-cpus request, it
    adds an annotation to hint runtime about the request. runtime
    is not aware of extended resources, hence we need the annotation.
  2. It validates the pod's QoS class and return an error if it's not a
    guaranteed QoS class
  3. It validates that no more than a single resource is being request.
  4. It validates that the pod deployed in a namespace that has mixedcpus
    workloads allowed annotation.

Which issue(s) this PR fixes:

Fixes # NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]:  https://github.com/openshift/enhancements/commit/76ea48a88bca15ef6157aacf90b8544a763e6075

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Dec 6, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
@openshift-ci-robot
Copy link

@Tal-or: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@Tal-or
Copy link
Author

Tal-or commented Dec 6, 2023

/retest

@rphillips
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
@mrunalp mrunalp removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Dec 6, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9f68be2 and 2 for PR HEAD 6335c48 in total

@Tal-or
Copy link
Author

Tal-or commented Dec 7, 2023

/retest

@Tal-or
Copy link
Author

Tal-or commented Dec 7, 2023

/test unit

@Tal-or
Copy link
Author

Tal-or commented Dec 7, 2023

/retest

@Tal-or
Copy link
Author

Tal-or commented Dec 7, 2023

/test unit

Adding a new mutation plugin that handles the following:

1. In case of `workload.openshift.io/enable-shared-cpus` request, it
   adds an annotation to hint runtime about the request. runtime
   is not aware of extended resources, hence we need the annotation.
2. It validates the pod's QoS class and return an error if it's not a
   guaranteed QoS class
3. It validates that no more than a single resource is being request.
4. It validates that the pod deployed in a namespace that has mixedcpus
   workloads allowed annotation.

For more information see - openshift/enhancements#1396

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
Copy link
Author

Tal-or commented Dec 7, 2023

/test unit

2 similar comments
@Tal-or
Copy link
Author

Tal-or commented Dec 7, 2023

/test unit

@Tal-or
Copy link
Author

Tal-or commented Dec 7, 2023

/test unit

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Dec 7, 2023
@openshift-ci-robot
Copy link

@Tal-or: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
@rphillips
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
Copy link

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: rphillips, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp mrunalp removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Dec 7, 2023
Copy link

openshift-ci bot commented Dec 7, 2023

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7aa0a74 into openshift:master Dec 7, 2023
19 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-hyperkube-container-v4.16.0-202312080609.p0.g7aa0a74.assembly.stream for distgit openshift-enterprise-hyperkube.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants