Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-25815: Fix device uncertain errors on reboot 4.12 #1833

Merged

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Dec 20, 2023

@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Dec 20, 2023
@openshift-ci-robot
Copy link

@gnufied: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@duanwei33
Copy link

/retest-required

@duanwei33
Copy link

duanwei33 commented Dec 21, 2023

The issue could be reproduced in 4.12.0-0.nightly-2023-12-18-194028, and when tested with the open PR, it did not hit the issue again.
It looks good from the QE side.

@gnufied gnufied changed the title UPSTREAM: 122211: Fix device uncertain errors on reboot UPSTREAM: 122211: Fix device uncertain errors on reboot 4.12 Dec 21, 2023
@gnufied gnufied changed the title UPSTREAM: 122211: Fix device uncertain errors on reboot 4.12 OCPBUGS-25815: Fix device uncertain errors on reboot 4.12 Dec 21, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 21, 2023
@openshift-ci-robot
Copy link

@gnufied: This pull request references Jira Issue OCPBUGS-25815, which is invalid:

  • expected dependent Jira Issue OCPBUGS-25814 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-25815

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member Author

gnufied commented Dec 21, 2023

/jira refresh

@openshift-ci-robot
Copy link

@gnufied: This pull request references Jira Issue OCPBUGS-25815, which is invalid:

  • expected dependent Jira Issue OCPBUGS-25814 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tsmetana
Copy link
Member

tsmetana commented Jan 4, 2024

/retest

@jsafrane
Copy link

jsafrane commented Jan 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2024
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 8, 2024
Copy link

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, jsafrane, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@duanwei33
Copy link

/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jan 9, 2024
@tsmetana
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

@tsmetana: This pull request references Jira Issue OCPBUGS-25815, which is invalid:

  • expected dependent Jira Issue OCPBUGS-25814 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@duanwei33
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 15, 2024
@openshift-ci-robot
Copy link

@duanwei33: This pull request references Jira Issue OCPBUGS-25815, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-25814 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-25814 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5c97f5b and 2 for PR HEAD 1f69bb4 in total

@gnufied
Copy link
Member Author

gnufied commented Jan 15, 2024

/retest

5 similar comments
@tsmetana
Copy link
Member

/retest

@tsmetana
Copy link
Member

/retest

@tsmetana
Copy link
Member

/retest

@tsmetana
Copy link
Member

/retest

@soltysh
Copy link
Member

soltysh commented Jan 18, 2024

/retest

@soltysh
Copy link
Member

soltysh commented Jan 18, 2024

This PR has sufficient pass rate (see https://prow.ci.openshift.org/pr-history/?org=openshift&repo=kubernetes&pr=1833), it looks like changes from openshift/release#47115 and openshift/release#47117 broke 4.12 branch.

/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/k8s-e2e-gcp-serial
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/verify-commits
/override ci/prow/k8s-e2e-gcp-ovn
/override ci/prow/k8s-e2e-conformance-aws
/override ci/prow/e2e-gcp
/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/integration
/override ci/prow/unit
/override ci/prow/verify
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/images
/override ci/prow/e2e-aws-ovn-crun

Copy link

openshift-ci bot commented Jan 18, 2024

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-agnostic-ovn-cmd, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-crun, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-gcp, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/images, ci/prow/integration, ci/prow/k8s-e2e-conformance-aws, ci/prow/k8s-e2e-gcp-ovn, ci/prow/k8s-e2e-gcp-serial, ci/prow/unit, ci/prow/verify, ci/prow/verify-commits

In response to this:

This PR has sufficient pass rate (see https://prow.ci.openshift.org/pr-history/?org=openshift&repo=kubernetes&pr=1833), it looks like changes from openshift/release#47115 and openshift/release#47117 broke 4.12 branch.

/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/k8s-e2e-gcp-serial
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/verify-commits
/override ci/prow/k8s-e2e-gcp-ovn
/override ci/prow/k8s-e2e-conformance-aws
/override ci/prow/e2e-gcp
/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/integration
/override ci/prow/unit
/override ci/prow/verify
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/images
/override ci/prow/e2e-aws-ovn-crun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Jan 18, 2024

@gnufied: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration 1f69bb4 link true /test integration
ci/prow/images 1f69bb4 link true /test images
ci/prow/e2e-aws-ovn-crun 1f69bb4 link true /test e2e-aws-ovn-crun
ci/prow/k8s-e2e-gcp-ovn 1f69bb4 link true /test k8s-e2e-gcp-ovn
ci/prow/unit 1f69bb4 link true /test unit
ci/prow/e2e-aws-ovn-cgroupsv2 1f69bb4 link true /test e2e-aws-ovn-cgroupsv2
ci/prow/verify 1f69bb4 link true /test verify
ci/prow/e2e-gcp-ovn-upgrade 1f69bb4 link true /test e2e-gcp-ovn-upgrade
ci/prow/k8s-e2e-gcp-serial 1f69bb4 link true /test k8s-e2e-gcp-serial
ci/prow/e2e-gcp 1f69bb4 link true /test e2e-gcp
ci/prow/e2e-aws-ovn-serial 1f69bb4 link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-fips 1f69bb4 link true /test e2e-aws-ovn-fips
ci/prow/verify-commits 1f69bb4 link true /test verify-commits
ci/prow/e2e-agnostic-ovn-cmd 1f69bb4 link false /test e2e-agnostic-ovn-cmd
ci/prow/k8s-e2e-conformance-aws 1f69bb4 link true /test k8s-e2e-conformance-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6df2177 into openshift:release-4.12 Jan 18, 2024
18 checks passed
@openshift-ci-robot
Copy link

@gnufied: Jira Issue OCPBUGS-25815: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25815 has been moved to the MODIFIED state.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-25815

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-pod-container-v4.12.0-202401181308.p0.g6df2177.assembly.stream for distgit openshift-enterprise-pod.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet