Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPNODE-1892: Bump k8s api to 1.29.0 #1840

Merged
merged 9 commits into from Jan 4, 2024
Merged

OCPNODE-1892: Bump k8s api to 1.29.0 #1840

merged 9 commits into from Jan 4, 2024

Conversation

sairameshv
Copy link
Member

/assign @soltysh

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jan 3, 2024
@openshift-ci-robot
Copy link

@sairameshv: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh January 3, 2024 12:32
@sairameshv sairameshv changed the title Bump 1.29.0 Bump k8s api to 1.29.0 Jan 3, 2024
@sairameshv sairameshv changed the title Bump k8s api to 1.29.0 OCPNODE-1892: Bump k8s api to 1.29.0 Jan 3, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2024 •
edited by openshift-ci bot

@sairameshv: This pull request references OCPNODE-1892 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

/assign @soltysh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sairameshv
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2024 •
edited by openshift-ci bot

@sairameshv: This pull request references OCPNODE-1892 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sairameshv
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2024 •
edited by openshift-ci bot

@sairameshv: This pull request references OCPNODE-1892 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sairameshv
Copy link
Member Author

/test k8s-e2e-gcp-ovn

@sairameshv
UPSTREAM: <drop>: hack/update-vendor.sh, make update and update image
460bfb6 
Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
@openshift-ci-robot
Copy link

@sairameshv: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@sairameshv
Copy link
Member Author

/test unit

@soltysh
Copy link
Member

soltysh commented Jan 4, 2024

/remove-label backports/unvalidated-commits
/label backports/validated-commits

soltysh
soltysh approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Jan 4, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sairameshv, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2024
@soltysh
Copy link
Member

soltysh commented Jan 4, 2024

/test e2e-gcp

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9368fcd and 2 for PR HEAD 460bfb6 in total

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 4, 2024

@sairameshv: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1de6a14 into openshift:master Jan 4, 2024
23 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-pod-container-v4.16.0-202401041812.p0.g1de6a14.assembly.stream for distgit openshift-enterprise-pod.
All builds following this will include this PR.

@sairameshv sairameshv deleted the bump-1.29.0 branch January 23, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sairameshv @openshift-ci-robot @soltysh @openshift-bot @k8s-release-robot @sanposhiho @k8s-ci-robot