Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE-910: [o/k-apis] Add context to ObjectValidator; Consume FeatureGate(s) in kube-apiserver #1852

Merged
merged 3 commits into from Mar 25, 2024
Merged

CFE-910: [o/k-apis] Add context to ObjectValidator; Consume FeatureGate(s) in kube-apiserver #1852

merged 3 commits into from Mar 25, 2024

Conversation

swghosh
Copy link
Member

@swghosh swghosh commented Jan 17, 2024 •
edited

This is a no-op change.

Partial follow-up of #1659

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jan 17, 2024
@openshift-ci-robot
Copy link

@swghosh: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

@swghosh: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jan 17, 2024
@openshift-ci-robot
Copy link

@swghosh: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@swghosh: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@swghosh: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@swghosh swghosh changed the title UPSTREAM: <carry>: Bump deps and add context to ObjectValidator UPSTREAM: <carry>: Add context to ObjectValidator, consume FeatureGate(s) in kube-apiserver, bump deps: o/api,lib-go Jan 18, 2024
@swghosh swghosh marked this pull request as ready for review January 18, 2024 08:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2024
@swghosh
Copy link
Member Author

swghosh commented Jan 18, 2024

/cc @p0lyn0mial

@swghosh
Copy link
Member Author

swghosh commented Jan 18, 2024

/cc @chiragkyal

@swghosh
Copy link
Member Author

swghosh commented Jan 18, 2024

/retest-required

@swghosh swghosh changed the title UPSTREAM: <carry>: Add context to ObjectValidator, consume FeatureGate(s) in kube-apiserver, bump deps: o/api,lib-go CFE-910: UPSTREAM: <carry>: Add context to ObjectValidator, consume FeatureGate(s) in kube-apiserver, bump deps: o/api,lib-go Jan 18, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 18, 2024 •
edited by openshift-ci bot

@swghosh: This pull request references CFE-910 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

In response to this:

Partial follow-up of #1659

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@swghosh
Copy link
Member Author

swghosh commented Jan 18, 2024

/retest-required

@swghosh
Copy link
Member Author

swghosh commented Jan 19, 2024

/test all

@swghosh swghosh changed the title CFE-910: UPSTREAM: <carry>: Add context to ObjectValidator, consume FeatureGate(s) in kube-apiserver, bump deps: o/api,lib-go CFE-910: No-op: UPSTREAM: <carry>: Add context to ObjectValidator, consume FeatureGate(s) in kube-apiserver, bump deps: o/api,lib-go Jan 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2024 •
edited by openshift-ci bot

@swghosh: This pull request references CFE-910 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

In response to this:

This is a no-op change.

Partial follow-up of #1659

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@chiragkyal
Copy link
Member

/test all

1 similar comment
@swghosh
Copy link
Member Author

swghosh commented Jan 22, 2024

/test all

@swghosh
Copy link
Member Author

swghosh commented Jan 22, 2024

/retest-required

@swghosh
Copy link
Member Author

swghosh commented Mar 5, 2024

/retest

@swghosh
Copy link
Member Author

swghosh commented Mar 5, 2024

/test unit

@swghosh
Copy link
Member Author

swghosh commented Mar 5, 2024

/retest

@swghosh
Copy link
Member Author

swghosh commented Mar 6, 2024

/test unit

soltysh
soltysh requested changes Mar 13, 2024
View reviewed changes
pkg/features/openshift_features.go Outdated Show resolved Hide resolved
openshift-kube-apiserver/openshiftkubeapiserver/flags.go Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link

@swghosh: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@swghosh
UPSTREAM: <drop>: Bump deps for api and library-go
23a9729 
- hack/pin-dependecy.sh github.com/openshift/api ae973131190ee375747ac8efad4d4bc077d6c4fd
- hack/pin-dependency.sh github.com/openshift/library-go 126b47137408f93a2fc9f2e8cbeedda61f9ebbfb
- hack/update-vendor.sh

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@swghosh
UPSTREAM: <carry>: Add openshift feature gates to kube-apiserver
f733049 
- inject openshift feature gates into pkg/features

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@openshift-ci-robot
Copy link

@swghosh: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

soltysh
soltysh approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Mar 15, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, swghosh, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@soltysh
Copy link
Member

soltysh commented Mar 15, 2024

/override ci/prow/unit
this is a known failure, I'm tracking elsewhere

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 15, 2024

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/unit

In response to this:

/override ci/prow/unit
this is a known failure, I'm tracking elsewhere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chiragkyal
Copy link
Member

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 91607f5 and 2 for PR HEAD f733049 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5a51bd8 and 1 for PR HEAD f733049 in total

@chiragkyal
Copy link
Member

/retest-required

@chiragkyal
Copy link
Member

/test e2e-gcp-ovn-upgrade
/test k8s-e2e-gcp-serial

@soltysh
Copy link
Member

soltysh commented Mar 25, 2024

/test k8s-e2e-gcp-serial

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 25, 2024

@swghosh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5fcea52 into openshift:master Mar 25, 2024
19 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-pod-container-v4.16.0-202403260112.p0.g5fcea52.assembly.stream.el9 for distgit openshift-enterprise-pod.
All builds following this will include this PR.

@swghosh swghosh mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@chiragkyal chiragkyal Awaiting requested review from chiragkyal

Assignees

@vrutkovs vrutkovs

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@swghosh @openshift-ci-robot @chiragkyal @vrutkovs @soltysh @openshift-bot