Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: Clean carry patches #1880

Merged
merged 4 commits into from Feb 15, 2024
Merged

NO-JIRA: Clean carry patches #1880

merged 4 commits into from Feb 15, 2024

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Feb 9, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Feb 9, 2024
@openshift-ci-robot
Copy link

@soltysh: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@soltysh
Copy link
Member Author

soltysh commented Feb 9, 2024

/test verify

@openshift-ci-robot
Copy link

@soltysh: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@openshift-ci-robot
Copy link

@soltysh: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Feb 9, 2024
@soltysh soltysh marked this pull request as ready for review February 9, 2024 17:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2024
@soltysh
Copy link
Member Author

soltysh commented Feb 12, 2024

/remove-label backports/unvalidated-commits
/remove-label backports/validated-commits

@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Feb 12, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 12, 2024

@soltysh: Those labels are not set on the issue: backports/validated-commits

In response to this:

/remove-label backports/unvalidated-commits
/remove-label backports/validated-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stlaz
stlaz reviewed Feb 12, 2024
View reviewed changes
openshift-hack/e2e/namespace.go Outdated
@@ -33,6 +33,9 @@ func CreateTestingNS(ctx context.Context, baseName string, c kclientset.Interfac
labels = map[string]string{}
}
labels["security.openshift.io/disable-securitycontextconstraints"] = "true"
// turn off the OpenShift label syncer so that it does not attempt to sync
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when is "isKubeNamespace" false?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In origin we have it set here: https://github.com/openshift/origin/blob/master/test/extended/util/test_setup.go#L89-L91, in k8s it's always true https://github.com/openshift/kubernetes/blob/master/openshift-hack/cmd/k8s-tests/provider.go#L103-L105

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it apply for all namespaces regardless of their name, please

stlaz
stlaz suggested changes Feb 12, 2024
View reviewed changes
openshift-hack/e2e/namespace.go Outdated
@@ -33,6 +33,9 @@ func CreateTestingNS(ctx context.Context, baseName string, c kclientset.Interfac
labels = map[string]string{}
}
labels["security.openshift.io/disable-securitycontextconstraints"] = "true"
// turn off the OpenShift label syncer so that it does not attempt to sync
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it apply for all namespaces regardless of their name, please

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Feb 12, 2024
@openshift-ci-robot
Copy link

@soltysh: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

stlaz
stlaz suggested changes Feb 12, 2024
View reviewed changes
Copy link
Member

@stlaz stlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM auth-wise.
Leaving review to @dinhxuanvu for the API things.

@soltysh
Copy link
Member Author

soltysh commented Feb 12, 2024 •
edited

/remove-label backports/unvalidated-commits
/remove-label backports/validated-commits
/hold
to make sure we don't break origin openshift/origin#28588

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2024
@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Feb 12, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 12, 2024

@soltysh: Those labels are not set on the issue: backports/validated-commits

In response to this:

/remove-label backports/unvalidated-commits
/remove-label backports/validated-commits
/hold
to make sure we don't break origin link origin PR here

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member Author

soltysh commented Feb 12, 2024

/label backports/validated-commits

@openshift-ci openshift-ci bot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Feb 12, 2024
@soltysh soltysh mentioned this pull request Feb 12, 2024
Closed
dinhxuanvu
dinhxuanvu reviewed Feb 12, 2024
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member Author

soltysh commented Feb 15, 2024

We have sufficient proof in openshift/origin#28588
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 15, 2024

@soltysh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit edc2c12 into openshift:master Feb 15, 2024
20 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-pod-container-v4.16.0-202402152340.p0.gedc2c12.assembly.stream.el9 for distgit openshift-enterprise-pod.
All builds following this will include this PR.

@soltysh soltysh deleted the clean_carries branch February 16, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu left review comments

@stlaz stlaz stlaz requested changes

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@dinhxuanvu dinhxuanvu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@soltysh @openshift-ci-robot @openshift-bot @stlaz @dinhxuanvu