OCPBUILD-13: UPSTREAM: <carry>: fix [sig-auth] ServiceAccounts no secret-based service account token should be auto-generated #1909
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@sanchezl: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
sanchezl
changed the title
sanchezl
force-pushed
the
no-token-secrets-01
branch
from
4ae632c
to
10ccd70
Compare
|
@sanchezl: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
…vice account token should be auto-generated
sanchezl
force-pushed
the
no-token-secrets-01
branch
from
10ccd70
to
1022a26
Compare
|
@sanchezl: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@sanchezl: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/remove-label backports/unvalidated-commits |
openshift-ci
bot
added
backports/validated-commits
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sanchezl, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
sanchezl
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@sanchezl: This pull request references OCPBUILD-13 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@sanchezl: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-pod-container-v4.16.0-202403261317.p0.g258f1d5.assembly.stream.el9 for distgit openshift-enterprise-pod. |
The upstream test:
[sig-auth] ServiceAccounts no secret-based service account token should be auto-generatedwas patched to tolerate the image pull secret generated by OCM for image registry auth.Update the test to not just ignore the generated image pull secret, but to also not fail when the secret is not generated.