Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: <drop>: Bump golang.org/x/net to v0.23.0 #1937

Closed

Conversation

flavianmissi
Copy link
Member

./hack/pin-dependency.sh golang.org/x/net v0.23.0
./hack/update-vendor.sh

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


./hack/pin-dependency.sh golang.org/x/net v0.23.0
./hack/update-vendor.sh

Signed-off-by: Flavian Missi <fmissi@redhat.com>
@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 4, 2024
@openshift-ci-robot
Copy link

@flavianmissi: This pull request references Jira Issue OCPBUGS-30844, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected Jira Issue OCPBUGS-30844 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

./hack/pin-dependency.sh golang.org/x/net v0.23.0
./hack/update-vendor.sh

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@flavianmissi: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh April 4, 2024 15:06
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Apr 4, 2024
Copy link

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flavianmissi
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2024
Copy link

openshift-ci bot commented Apr 4, 2024

@flavianmissi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 2ceeb91 link true /test e2e-gcp
ci/prow/k8s-e2e-gcp-serial 2ceeb91 link true /test k8s-e2e-gcp-serial
ci/prow/unit 2ceeb91 link true /test unit
ci/prow/k8s-e2e-gcp-ovn 2ceeb91 link true /test k8s-e2e-gcp-ovn
ci/prow/e2e-agnostic-ovn-cmd 2ceeb91 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-gcp-ovn-upgrade 2ceeb91 link true /test e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@flavianmissi flavianmissi changed the title OCPBUGS-30844: UPSTREAM: <drop>: Bump golang.org/x/net to v0.23.0 UPSTREAM: <drop>: Bump golang.org/x/net to v0.23.0 Apr 5, 2024
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 5, 2024
@openshift-ci-robot
Copy link

@flavianmissi: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

./hack/pin-dependency.sh golang.org/x/net v0.23.0
./hack/update-vendor.sh

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 5, 2024
@flavianmissi
Copy link
Member Author

upstream has already merged this bump on 1.27. since we've landed the openshift-priv changes already, we don't need this PR. next time we bump this repo with upstream kube we'll get the x/net bump and everything will be right again.
/close

Copy link

openshift-ci bot commented Apr 5, 2024

@flavianmissi: Closed this PR.

In response to this:

upstream has already merged this bump on 1.27. since we've landed the openshift-priv changes already, we don't need this PR. next time we bump this repo with upstream kube we'll get the x/net bump and everything will be right again.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants