[4.14] OCPBUGS-32580: allow override of NewVolumeManagerReconstruction #1956

dobsonj · 2024-04-24T20:49:59Z

https://issues.redhat.com/browse/OCPBUGS-32580

This provides a way to set the NewVolumeManagerReconstruction feature gate in a way that still allows the cluster to be upgradable. This is only needed on 4.14, since the feature gate defaults to true on 4.15 and later.

To test, you can log into a 4.14 node, install the following test rpm, and set the environment variable in /etc/kubernetes/kubelet-env:

$ oc debug node/ip-10-0-92-74.us-east-2.compute.internal
Starting pod/ip-10-0-92-74us-east-2computeinternal-debug-nkwpd ...
To use host binaries, run `chroot /host`
Pod IP: 10.0.92.74
If you don't see a command prompt, try pressing enter.
sh-4.4# chroot /host

sh-5.1# rpm-ostree override replace https://files.dobsonj.com/openshift-hyperkube-1.27.13-1.0.401bb48.x86_64.rpm

sh-5.1# vi /etc/kubernetes/kubelet-env
sh-5.1# cat /etc/kubernetes/kubelet-env
OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION=true
sh-5.1# systemctl reboot

If it was successful, kubelet should have a log message showing that the environment variable took effect, and the NewVolumeManagerReconstruction feature gate should be true.

sh-5.1# journalctl -u kubelet | grep -m1 OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION
Apr 24 20:24:18 ip-10-0-92-74 kubenswrapper[2052]: I0424 20:24:18.141491    2052 patch_kube_features.go:19] Environment variable OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION is set, setting feature gate NewVolumeManagerReconstruction to true

sh-5.1# journalctl -u kubelet | grep -m1 'feature gates: .*NewVolumeManagerReconstruction'
Apr 24 20:24:18 ip-10-0-92-74 kubenswrapper[2052]: I0424 20:24:18.198774    2052 feature_gate.go:250] feature gates: &{map[AdmissionWebhookMatchConditions:false CloudDualStackNodeIPs:true DynamicResourceAllocation:false EventedPLEG:false MaxUnavailableStatefulSet:false NewVolumeManagerReconstruction:true NodeSwap:false RetroactiveDefaultStorageClass:false ValidatingAdmissionPolicy:false]}

/cc @openshift/storage @jsafrane @rphillips

…econstruction

openshift-ci-robot · 2024-04-24T20:50:05Z

@dobsonj: This pull request references Jira Issue OCPBUGS-32580, which is invalid:

expected the bug to target the "4.14.z" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected Jira Issue OCPBUGS-32580 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-32580

This provides a way to set the NewVolumeManagerReconstruction feature gate in a way that still allows the cluster to be upgradable. This is only needed on 4.14, since the feature gate defaults to true on 4.15 and later.

To test, you can log into a 4.14 node, install the following test rpm, and set the environment variable in /etc/kubernetes/kubelet-env:

$ oc debug node/ip-10-0-92-74.us-east-2.compute.internal
Starting pod/ip-10-0-92-74us-east-2computeinternal-debug-nkwpd ...
To use host binaries, run `chroot /host`
Pod IP: 10.0.92.74
If you don't see a command prompt, try pressing enter.
sh-4.4# chroot /host

sh-5.1# rpm-ostree override replace https://files.dobsonj.com/openshift-hyperkube-1.27.13-1.0.401bb48.x86_64.rpm

sh-5.1# vi /etc/kubernetes/kubelet-env
sh-5.1# cat /etc/kubernetes/kubelet-env
OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION=true
sh-5.1# systemctl reboot

If it was successful, kubelet should have a log message showing that the environment variable took effect, and the NewVolumeManagerReconstruction feature gate should be true.

sh-5.1# journalctl -u kubelet | grep -m1 OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION
Apr 24 20:24:18 ip-10-0-92-74 kubenswrapper[2052]: I0424 20:24:18.141491    2052 patch_kube_features.go:19] Environment variable OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION is set, setting feature gate NewVolumeManagerReconstruction to true

sh-5.1# journalctl -u kubelet | grep -m1 'feature gates: .*NewVolumeManagerReconstruction'
Apr 24 20:24:18 ip-10-0-92-74 kubenswrapper[2052]: I0424 20:24:18.198774    2052 feature_gate.go:250] feature gates: &{map[AdmissionWebhookMatchConditions:false CloudDualStackNodeIPs:true DynamicResourceAllocation:false EventedPLEG:false MaxUnavailableStatefulSet:false NewVolumeManagerReconstruction:true NodeSwap:false RetroactiveDefaultStorageClass:false ValidatingAdmissionPolicy:false]}

/cc @openshift/storage @jsafrane

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-04-24T20:50:09Z

@dobsonj: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

b152eb3|UPSTREAM: : OCPBUGS-32580: allow override of NewVolumeManagerReconstruction: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci · 2024-04-24T20:50:11Z

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-32580

This provides a way to set the NewVolumeManagerReconstruction feature gate in a way that still allows the cluster to be upgradable. This is only needed on 4.14, since the feature gate defaults to true on 4.15 and later.

To test, you can log into a 4.14 node, install the following test rpm, and set the environment variable in /etc/kubernetes/kubelet-env:

$ oc debug node/ip-10-0-92-74.us-east-2.compute.internal
Starting pod/ip-10-0-92-74us-east-2computeinternal-debug-nkwpd ...
To use host binaries, run `chroot /host`
Pod IP: 10.0.92.74
If you don't see a command prompt, try pressing enter.
sh-4.4# chroot /host

sh-5.1# rpm-ostree override replace https://files.dobsonj.com/openshift-hyperkube-1.27.13-1.0.401bb48.x86_64.rpm

sh-5.1# vi /etc/kubernetes/kubelet-env
sh-5.1# cat /etc/kubernetes/kubelet-env
OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION=true
sh-5.1# systemctl reboot

If it was successful, kubelet should have a log message showing that the environment variable took effect, and the NewVolumeManagerReconstruction feature gate should be true.

sh-5.1# journalctl -u kubelet | grep -m1 OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION
Apr 24 20:24:18 ip-10-0-92-74 kubenswrapper[2052]: I0424 20:24:18.141491    2052 patch_kube_features.go:19] Environment variable OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION is set, setting feature gate NewVolumeManagerReconstruction to true

sh-5.1# journalctl -u kubelet | grep -m1 'feature gates: .*NewVolumeManagerReconstruction'
Apr 24 20:24:18 ip-10-0-92-74 kubenswrapper[2052]: I0424 20:24:18.198774    2052 feature_gate.go:250] feature gates: &{map[AdmissionWebhookMatchConditions:false CloudDualStackNodeIPs:true DynamicResourceAllocation:false EventedPLEG:false MaxUnavailableStatefulSet:false NewVolumeManagerReconstruction:true NodeSwap:false RetroactiveDefaultStorageClass:false ValidatingAdmissionPolicy:false]}

/cc @openshift/storage @jsafrane

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dobsonj · 2024-04-24T22:05:23Z

pkg/features/patch_kube_features.go

+func init() {
+	OpenShiftNewVolumeManagerReconstructionOverride()
+}


In case anyone else has the same question I had: What happens when two files in a single package both have their own init() routine?

The files are processed alphabetically. First the init() in kube_features.go is called, and then the init() here in patch_kube_features.go. They are always called exactly once, in serial, in order.

In other words, OpenShiftNewVolumeManagerReconstructionOverride() should always be called after the default feature gates are added.

It would be nice to have this information as a comment in the code

dobsonj · 2024-04-24T22:12:49Z

/jira refresh

openshift-ci-robot · 2024-04-24T22:12:56Z

@dobsonj: This pull request references Jira Issue OCPBUGS-32580, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-32938 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-32938 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-04-24T22:14:49Z

@dobsonj: This pull request references Jira Issue OCPBUGS-32580, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-32938 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-32938 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-32580

This provides a way to set the NewVolumeManagerReconstruction feature gate in a way that still allows the cluster to be upgradable. This is only needed on 4.14, since the feature gate defaults to true on 4.15 and later.

To test, you can log into a 4.14 node, install the following test rpm, and set the environment variable in /etc/kubernetes/kubelet-env:
$ oc debug node/ip-10-0-92-74.us-east-2.compute.internal
Starting pod/ip-10-0-92-74us-east-2computeinternal-debug-nkwpd ...
To use host binaries, run `chroot /host`
Pod IP: 10.0.92.74
If you don't see a command prompt, try pressing enter.
sh-4.4# chroot /host

sh-5.1# rpm-ostree override replace https://files.dobsonj.com/openshift-hyperkube-1.27.13-1.0.401bb48.x86_64.rpm

sh-5.1# vi /etc/kubernetes/kubelet-env
sh-5.1# cat /etc/kubernetes/kubelet-env
OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION=true
sh-5.1# systemctl reboot
If it was successful, kubelet should have a log message showing that the environment variable took effect, and the NewVolumeManagerReconstruction feature gate should be true.
sh-5.1# journalctl -u kubelet | grep -m1 OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION
Apr 24 20:24:18 ip-10-0-92-74 kubenswrapper[2052]: I0424 20:24:18.141491    2052 patch_kube_features.go:19] Environment variable OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION is set, setting feature gate NewVolumeManagerReconstruction to true

sh-5.1# journalctl -u kubelet | grep -m1 'feature gates: .*NewVolumeManagerReconstruction'
Apr 24 20:24:18 ip-10-0-92-74 kubenswrapper[2052]: I0424 20:24:18.198774    2052 feature_gate.go:250] feature gates: &{map[AdmissionWebhookMatchConditions:false CloudDualStackNodeIPs:true DynamicResourceAllocation:false EventedPLEG:false MaxUnavailableStatefulSet:false NewVolumeManagerReconstruction:true NodeSwap:false RetroactiveDefaultStorageClass:false ValidatingAdmissionPolicy:false]}
/cc @openshift/storage @jsafrane @rphillips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-04-25T00:07:57Z

@dobsonj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-ovn-cmd	`b152eb3`	link	false	`/test e2e-agnostic-ovn-cmd`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

duanwei33 · 2024-04-25T11:49:44Z

We can reproduce it in the latest 4.14 payload. (See reproducer in OCPBUGS-32580)
With the open PR + setting the environment variable in /etc/kubernetes/kubelet-env in the node, the issue is not reproduced. Although we need additional test like upgrade, but the fix looks good.

jsafrane · 2024-04-25T15:01:42Z

/lgtm

duanwei33 · 2024-04-25T23:10:08Z

/label qe-approved
/label cherry-pick-approved

openshift-ci-robot · 2024-04-25T23:10:14Z

@dobsonj: This pull request references Jira Issue OCPBUGS-32580, which is valid.

9 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-32955 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent bug Jira Issue OCPBUGS-32938 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-32955 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
dependent Jira Issue OCPBUGS-32938 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-32580

This provides a way to set the NewVolumeManagerReconstruction feature gate in a way that still allows the cluster to be upgradable. This is only needed on 4.14, since the feature gate defaults to true on 4.15 and later.

To test, you can log into a 4.14 node, install the following test rpm, and set the environment variable in /etc/kubernetes/kubelet-env:
$ oc debug node/ip-10-0-92-74.us-east-2.compute.internal
Starting pod/ip-10-0-92-74us-east-2computeinternal-debug-nkwpd ...
To use host binaries, run `chroot /host`
Pod IP: 10.0.92.74
If you don't see a command prompt, try pressing enter.
sh-4.4# chroot /host

sh-5.1# rpm-ostree override replace https://files.dobsonj.com/openshift-hyperkube-1.27.13-1.0.401bb48.x86_64.rpm

sh-5.1# vi /etc/kubernetes/kubelet-env
sh-5.1# cat /etc/kubernetes/kubelet-env
OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION=true
sh-5.1# systemctl reboot
If it was successful, kubelet should have a log message showing that the environment variable took effect, and the NewVolumeManagerReconstruction feature gate should be true.
sh-5.1# journalctl -u kubelet | grep -m1 OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION
Apr 24 20:24:18 ip-10-0-92-74 kubenswrapper[2052]: I0424 20:24:18.141491    2052 patch_kube_features.go:19] Environment variable OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION is set, setting feature gate NewVolumeManagerReconstruction to true

sh-5.1# journalctl -u kubelet | grep -m1 'feature gates: .*NewVolumeManagerReconstruction'
Apr 24 20:24:18 ip-10-0-92-74 kubenswrapper[2052]: I0424 20:24:18.198774    2052 feature_gate.go:250] feature gates: &{map[AdmissionWebhookMatchConditions:false CloudDualStackNodeIPs:true DynamicResourceAllocation:false EventedPLEG:false MaxUnavailableStatefulSet:false NewVolumeManagerReconstruction:true NodeSwap:false RetroactiveDefaultStorageClass:false ValidatingAdmissionPolicy:false]}
/cc @openshift/storage @jsafrane @rphillips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jsafrane · 2024-04-30T12:13:30Z

/retest-require
this PR does not touch GCP code.

jsafrane · 2024-04-30T12:53:08Z

/retest-required

rphillips · 2024-04-30T13:46:24Z

/lgtm
/label backport-risk-assessed

deads2k · 2024-04-30T14:11:40Z

@rphillips on your head be it.

/approve

openshift-ci · 2024-04-30T14:12:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dobsonj, jsafrane, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-04-30T15:30:03Z

@dobsonj: Jira Issue OCPBUGS-32580: All pull requests linked via external trackers have merged:

openshift/kubernetes#1956

Jira Issue OCPBUGS-32580 has been moved to the MODIFIED state.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-32580

This provides a way to set the NewVolumeManagerReconstruction feature gate in a way that still allows the cluster to be upgradable. This is only needed on 4.14, since the feature gate defaults to true on 4.15 and later.

To test, you can log into a 4.14 node, install the following test rpm, and set the environment variable in /etc/kubernetes/kubelet-env:
$ oc debug node/ip-10-0-92-74.us-east-2.compute.internal
Starting pod/ip-10-0-92-74us-east-2computeinternal-debug-nkwpd ...
To use host binaries, run `chroot /host`
Pod IP: 10.0.92.74
If you don't see a command prompt, try pressing enter.
sh-4.4# chroot /host

sh-5.1# rpm-ostree override replace https://files.dobsonj.com/openshift-hyperkube-1.27.13-1.0.401bb48.x86_64.rpm

sh-5.1# vi /etc/kubernetes/kubelet-env
sh-5.1# cat /etc/kubernetes/kubelet-env
OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION=true
sh-5.1# systemctl reboot
If it was successful, kubelet should have a log message showing that the environment variable took effect, and the NewVolumeManagerReconstruction feature gate should be true.
sh-5.1# journalctl -u kubelet | grep -m1 OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION
Apr 24 20:24:18 ip-10-0-92-74 kubenswrapper[2052]: I0424 20:24:18.141491    2052 patch_kube_features.go:19] Environment variable OCP_4_14_SUPPORT_EXCEPTION_ENABLE_NEW_VOLUME_MANAGER_RECONSTRUCTION is set, setting feature gate NewVolumeManagerReconstruction to true

sh-5.1# journalctl -u kubelet | grep -m1 'feature gates: .*NewVolumeManagerReconstruction'
Apr 24 20:24:18 ip-10-0-92-74 kubenswrapper[2052]: I0424 20:24:18.198774    2052 feature_gate.go:250] feature gates: &{map[AdmissionWebhookMatchConditions:false CloudDualStackNodeIPs:true DynamicResourceAllocation:false EventedPLEG:false MaxUnavailableStatefulSet:false NewVolumeManagerReconstruction:true NodeSwap:false RetroactiveDefaultStorageClass:false ValidatingAdmissionPolicy:false]}
/cc @openshift/storage @jsafrane @rphillips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-04-30T19:33:15Z

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-pod-container-v4.14.0-202404301807.p0.gfd36fb9.assembly.stream.el8 for distgit openshift-enterprise-pod.
All builds following this will include this PR.

openshift-merge-robot · 2024-05-01T08:40:04Z

Fix included in accepted release 4.14.0-0.nightly-2024-05-01-032909

UPSTREAM: <carry>: OCPBUGS-32580: allow override of NewVolumeManagerR…

b152eb3

…econstruction

openshift-ci bot requested a review from jsafrane April 24, 2024 20:50

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 24, 2024

dobsonj commented Apr 24, 2024

View reviewed changes

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2024

openshift-ci bot assigned jsafrane Apr 25, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024

openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Apr 25, 2024

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 30, 2024

openshift-ci bot assigned duanwei33 and gangwgr Apr 30, 2024

openshift-ci bot assigned kasturinarra, sunilcio, wangke19, xingxingxia, zhouying7780 and rphillips Apr 30, 2024

openshift-merge-bot bot merged commit fd36fb9 into openshift:release-4.14 Apr 30, 2024
18 of 19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.14] OCPBUGS-32580: allow override of NewVolumeManagerReconstruction #1956

[4.14] OCPBUGS-32580: allow override of NewVolumeManagerReconstruction #1956

dobsonj commented Apr 24, 2024 •

edited

openshift-ci-robot commented Apr 24, 2024

openshift-ci-robot commented Apr 24, 2024

openshift-ci bot commented Apr 24, 2024

dobsonj Apr 24, 2024

jsafrane Apr 26, 2024 •

edited

dobsonj commented Apr 24, 2024

openshift-ci-robot commented Apr 24, 2024

openshift-ci-robot commented Apr 24, 2024

openshift-ci bot commented Apr 25, 2024 •

edited

duanwei33 commented Apr 25, 2024

jsafrane commented Apr 25, 2024

duanwei33 commented Apr 25, 2024

openshift-ci-robot commented Apr 25, 2024

jsafrane commented Apr 30, 2024

jsafrane commented Apr 30, 2024

rphillips commented Apr 30, 2024

deads2k commented Apr 30, 2024

openshift-ci bot commented Apr 30, 2024

openshift-ci-robot commented Apr 30, 2024

openshift-bot commented Apr 30, 2024

openshift-merge-robot commented May 1, 2024

[4.14] OCPBUGS-32580: allow override of NewVolumeManagerReconstruction #1956

[4.14] OCPBUGS-32580: allow override of NewVolumeManagerReconstruction #1956

Conversation

dobsonj commented Apr 24, 2024 • edited

openshift-ci-robot commented Apr 24, 2024

openshift-ci-robot commented Apr 24, 2024

openshift-ci bot commented Apr 24, 2024

dobsonj Apr 24, 2024

Choose a reason for hiding this comment

jsafrane Apr 26, 2024 • edited

Choose a reason for hiding this comment

dobsonj commented Apr 24, 2024

openshift-ci-robot commented Apr 24, 2024

openshift-ci-robot commented Apr 24, 2024

openshift-ci bot commented Apr 25, 2024 • edited

duanwei33 commented Apr 25, 2024

jsafrane commented Apr 25, 2024

duanwei33 commented Apr 25, 2024

openshift-ci-robot commented Apr 25, 2024

jsafrane commented Apr 30, 2024

jsafrane commented Apr 30, 2024

rphillips commented Apr 30, 2024

deads2k commented Apr 30, 2024

openshift-ci bot commented Apr 30, 2024

openshift-ci-robot commented Apr 30, 2024

openshift-bot commented Apr 30, 2024

openshift-merge-robot commented May 1, 2024

dobsonj commented Apr 24, 2024 •

edited

jsafrane Apr 26, 2024 •

edited

openshift-ci bot commented Apr 25, 2024 •

edited