Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-1809: Provide SCC access via RBAC #1959

Merged
merged 1 commit into from
May 6, 2024

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented May 2, 2024

Instead of providing SCC access when running tests by modifying the SCC, just use RBAC and the existing system cluster roles

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 2, 2024
@openshift-ci-robot
Copy link

@cblecker: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh May 2, 2024 00:45
@cblecker cblecker changed the title Provide SCC access via RBAC API-1809: Provide SCC access via RBAC May 3, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 3, 2024

@cblecker: This pull request references API-1809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instead of providing SCC access when running tests by modifying the SCC, just use RBAC and the existing system cluster roles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cblecker
Copy link
Member Author

cblecker commented May 3, 2024

/test unit integration

@openshift-ci-robot
Copy link

@cblecker: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@cblecker
Copy link
Member Author

cblecker commented May 4, 2024

/retest-required

Copy link

openshift-ci bot commented May 4, 2024

@cblecker: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd 8fc74ee link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@soltysh
Copy link
Member

soltysh commented May 6, 2024

/remove-label backports/unvalidated-commits
/label backports/unvalidated-commits

@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 6, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
Copy link

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 681e46b into openshift:master May 6, 2024
19 of 20 checks passed
@cblecker cblecker deleted the e2e-fix branch May 6, 2024 17:21
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-pod-container-v4.16.0-202405062116.p0.g681e46b.assembly.stream.el9 for distgit openshift-enterprise-pod.
All builds following this will include this PR.

@soltysh
Copy link
Member

soltysh commented May 7, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot

@soltysh: new pull request created: #1962

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member

soltysh commented May 8, 2024

/cherry-pick release-4.14
/cherry-pick release-4.13

@openshift-cherrypick-robot

@soltysh: new pull request created: #1965

In response to this:

/cherry-pick release-4.14
/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member

soltysh commented May 23, 2024

/cherry-pick release-4.13

@openshift-cherrypick-robot

@soltysh: #1959 failed to apply on top of branch "release-4.13":

Applying: UPSTREAM: <carry>: Provide SCC access via RBAC
Using index info to reconstruct a base tree...
A	openshift-hack/e2e/namespace.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): openshift-hack/e2e/namespace.go deleted in HEAD and modified in UPSTREAM: <carry>: Provide SCC access via RBAC. Version UPSTREAM: <carry>: Provide SCC access via RBAC of openshift-hack/e2e/namespace.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 UPSTREAM: <carry>: Provide SCC access via RBAC
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants