Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 93658: test/e2e: fail test rather than flooding logs if PVC watch is closed prematurely #306

Merged
merged 1 commit into from Aug 6, 2020

Conversation

huffmanca
Copy link

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
Backports kubernetes#93658 . This PR addresses an incorrectly written test where we didn't fail the test if the watch was closed prematurely.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@openshift-ci-robot openshift-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Aug 5, 2020
@huffmanca
Copy link
Author

/retest

2 similar comments
@huffmanca
Copy link
Author

/retest

@huffmanca
Copy link
Author

/retest

@mrunalp
Copy link
Member

mrunalp commented Aug 5, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2020
@huffmanca
Copy link
Author

//retest

@huffmanca
Copy link
Author

/retest

@openshift-ci-robot
Copy link

@huffmanca: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-cmd a4f2d17 link /test e2e-cmd
ci/prow/e2e-aws-csi a4f2d17 link /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link

jsafrane commented Aug 6, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca, jsafrane, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5241b27 into openshift:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants